Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 150153003: Revert of aura: Remove old GL paths from RenderWidgetHostViewAura. (Closed)

Created:
6 years, 10 months ago by pdr.
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Visibility:
Public.

Description

Revert of aura: Remove old GL paths from RenderWidgetHostViewAura. (https://codereview.chromium.org/131443007/) Reason for revert: This patch is causing hundreds of layouttest timouts in Blink (see: http://goo.gl/6tX16t). My investigation is at crbug.com/341344. I'm going to roll this out for now to try to green the Blink tree. BUG=341344 Original issue's description: > aura: Remove old GL paths from RenderWidgetHostViewAura. > > Frames from the renderer are either legacy software, > software compositing, or ubercomp. Remove the old GL composited > paths that are no longer in use. > > R=piman > BUG=332998 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249226 TBR=piman@chromium.org,fsamuel@chromium.org,phajdan.jr@chromium.org,danakj@chromium.org NOTREECHECKS=true NOTRY=true BUG=332998 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249298

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+470 lines, -64 lines) Patch
M chrome/browser/about_flags.cc View 5 chunks +4 lines, -13 lines 0 comments Download
M chrome/browser/apps/web_view_browsertest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_host_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/input/touch_input_browsertest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 8 chunks +44 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 23 chunks +354 lines, -27 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 5 chunks +64 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pdr.
Created Revert of aura: Remove old GL paths from RenderWidgetHostViewAura.
6 years, 10 months ago (2014-02-06 08:03:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/150153003/1
6 years, 10 months ago (2014-02-06 08:07:24 UTC) #2
commit-bot: I haz the power
6 years, 10 months ago (2014-02-06 08:11:04 UTC) #3
Message was sent while issue was closed. 
Change committed as 249298

Powered by Google App Engine
This is Rietveld 408576698