Issue 1501493003: Pull HTTP/2 header parsing into utility method, from QuicSpdy{Client,Server}Streams. Not used in pr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1501493003: Pull HTTP/2 header parsing into utility method, from QuicSpdy{Client,Server}Streams. Not used in pr… (Closed)

Created:
5 years ago by Jo Kulik

Modified:
5 years ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@108651883

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Pull HTTP/2 header parsing into utility method, from QuicSpdy{Client,Server}Streams. Not used in production. Preparation for adding a ParseTrailers method, which will sit alongside ParseHeaders in SpdyUtils. Makes it easier to unit test, demonstrated with newly added spdy_utils_test.cc. Slight behavior change in that the ClientStream now gets support for handling multiple content-length headers, which was added to the ServerStream recently. Otherwise should be the same. Merge internal change: 108694474 R=rch@chromium.org BUG=

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -65 lines)			Patch
M	net/quic/spdy_utils.h	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	net/quic/spdy_utils.cc	View	2 chunks	+41 lines, -0 lines	0 comments	Download
M	net/tools/quic/quic_spdy_client_stream.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/tools/quic/quic_spdy_client_stream.cc	View	2 chunks	+15 lines, -27 lines	0 comments	Download
M	net/tools/quic/quic_spdy_server_stream.cc	View	2 chunks	+3 lines, -36 lines	0 comments	Download

Dependent Patchsets:

Issue 1494403002 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages