Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 150144: linux: make layout test plugin build and run in test_shell (Closed)

Created:
11 years, 5 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
Antoine Labour, jam, awalker, Dean McNamee
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

linux: make layout test plugin build and run in test_shell I used the upstream implementation as a guide for the changes I made, so style faults are theirs. Also includes updates to test_expectations for the new tests we pass, and one new baseline for a test that had an output image that we match Windows on aside from antialiasing. BUG=11516

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -37 lines) Patch
A webkit/data/layout_tests/platform/chromium-linux/chrome/plugins/return-npobject-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/chrome/plugins/return-npobject-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/tools/layout_tests/test_expectations.txt View 4 chunks +24 lines, -26 lines 0 comments Download
M webkit/tools/npapi_layout_test_plugin/main.cpp View 2 chunks +60 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Martin
piman: review changes to plugin to match linux plugin api (I copied from upstream, so ...
11 years, 5 months ago (2009-07-01 00:12:13 UTC) #1
Antoine Labour
11 years, 5 months ago (2009-07-01 00:34:59 UTC) #2
LGTM. I'm curious about why some javascript-related tests still fail on linux,
since that part should be mostly platform-independent.
Anyway, it looks good. I compared to what we do in O3D and that matches.

Powered by Google App Engine
This is Rietveld 408576698