Issue 150143002: [Files.app] Fix the licence error of audio_player_scripts.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150143002: [Files.app] Fix the licence error of audio_player_scripts.js (Closed)

Created:
6 years, 10 months ago by yoshiki

Modified:
6 years, 10 months ago

Reviewers:
yoshiki, boliu

CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, android-webview-reviews_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Files.app] Fix the licence error of audio_player_scripts.js This patch fixes the build failure of the 'check_licenses' test in 'Android Builder (dbg)'. Major changes: - Modify the year in the copyright string in audio_player_scripts.js - Put audio_player_scripts.js into the whitelist BUG=none TEST=manually run android_webview/tools/webview_licenses.py scan TBR=boliu@chromium.org, yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247896

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	android_webview/tools/third_party_files_whitelist.txt	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	chrome/browser/resources/file_manager/audio_player/js/audio_player_scripts.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

yoshiki

Committed patchset #1 manually as r247896 (presubmit successful).

6 years, 10 months ago (2014-01-30 08:30:12 UTC) #1

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages