Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1501413005: Add the entire runtime team to js owners file (Closed)

Created:
5 years ago by Toon Verwaest
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add the entire runtime team to js owners file BUG= Committed: https://crrev.com/e62b24d2f70defd62c871e58364bc25df6e2ca25 Cr-Commit-Position: refs/heads/master@{#32680}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/js/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Toon Verwaest
ptal
5 years ago (2015-12-08 10:10:52 UTC) #2
Yang
On 2015/12/08 10:10:52, Toon Verwaest wrote: > ptal lgtm.
5 years ago (2015-12-08 10:11:08 UTC) #3
Michael Starzinger
LGTM. I sign the petition.
5 years ago (2015-12-08 10:18:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1501413005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1501413005/1
5 years ago (2015-12-08 10:19:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/11138)
5 years ago (2015-12-08 11:17:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1501413005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1501413005/1
5 years ago (2015-12-08 16:39:36 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-08 19:07:39 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-08 19:08:22 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e62b24d2f70defd62c871e58364bc25df6e2ca25
Cr-Commit-Position: refs/heads/master@{#32680}

Powered by Google App Engine
This is Rietveld 408576698