Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: src/code-stubs-hydrogen.cc

Issue 15014020: Elide hole checks on KeyedLoads of holey double arrays. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Implement missing platforms and add tests Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 400 matching lines...) Expand 10 before | Expand all | Expand 10 after
411 Handle<Code> FastCloneShallowObjectStub::GenerateCode() { 411 Handle<Code> FastCloneShallowObjectStub::GenerateCode() {
412 return DoGenerateCode(this); 412 return DoGenerateCode(this);
413 } 413 }
414 414
415 415
416 template <> 416 template <>
417 HValue* CodeStubGraphBuilder<KeyedLoadFastElementStub>::BuildCodeStub() { 417 HValue* CodeStubGraphBuilder<KeyedLoadFastElementStub>::BuildCodeStub() {
418 HInstruction* load = BuildUncheckedMonomorphicElementAccess( 418 HInstruction* load = BuildUncheckedMonomorphicElementAccess(
419 GetParameter(0), GetParameter(1), NULL, NULL, 419 GetParameter(0), GetParameter(1), NULL, NULL,
420 casted_stub()->is_js_array(), casted_stub()->elements_kind(), 420 casted_stub()->is_js_array(), casted_stub()->elements_kind(),
421 false, STANDARD_STORE, Representation::Tagged()); 421 false, NEVER_RETURN_HOLE, STANDARD_STORE, Representation::Tagged());
422 return load; 422 return load;
423 } 423 }
424 424
425 425
426 Handle<Code> KeyedLoadFastElementStub::GenerateCode() { 426 Handle<Code> KeyedLoadFastElementStub::GenerateCode() {
427 return DoGenerateCode(this); 427 return DoGenerateCode(this);
428 } 428 }
429 429
430 430
431 template<> 431 template<>
(...skipping 24 matching lines...) Expand all
456 Handle<Code> KeyedLoadFieldStub::GenerateCode() { 456 Handle<Code> KeyedLoadFieldStub::GenerateCode() {
457 return DoGenerateCode(this); 457 return DoGenerateCode(this);
458 } 458 }
459 459
460 460
461 template <> 461 template <>
462 HValue* CodeStubGraphBuilder<KeyedStoreFastElementStub>::BuildCodeStub() { 462 HValue* CodeStubGraphBuilder<KeyedStoreFastElementStub>::BuildCodeStub() {
463 BuildUncheckedMonomorphicElementAccess( 463 BuildUncheckedMonomorphicElementAccess(
464 GetParameter(0), GetParameter(1), GetParameter(2), NULL, 464 GetParameter(0), GetParameter(1), GetParameter(2), NULL,
465 casted_stub()->is_js_array(), casted_stub()->elements_kind(), 465 casted_stub()->is_js_array(), casted_stub()->elements_kind(),
466 true, casted_stub()->store_mode(), Representation::Tagged()); 466 true, NEVER_RETURN_HOLE, casted_stub()->store_mode(),
467 Representation::Tagged());
467 468
468 return GetParameter(2); 469 return GetParameter(2);
469 } 470 }
470 471
471 472
472 Handle<Code> KeyedStoreFastElementStub::GenerateCode() { 473 Handle<Code> KeyedStoreFastElementStub::GenerateCode() {
473 return DoGenerateCode(this); 474 return DoGenerateCode(this);
474 } 475 }
475 476
476 477
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
693 ? graph()->GetConstantSmi1() 694 ? graph()->GetConstantSmi1()
694 : graph()->GetConstantUndefined(); 695 : graph()->GetConstantUndefined();
695 } 696 }
696 697
697 698
698 Handle<Code> CompareNilICStub::GenerateCode() { 699 Handle<Code> CompareNilICStub::GenerateCode() {
699 return DoGenerateCode(this); 700 return DoGenerateCode(this);
700 } 701 }
701 702
702 } } // namespace v8::internal 703 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/bootstrapper.cc ('k') | src/contexts.h » ('j') | src/isolate.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698