Issue 15014020: Elide hole checks on KeyedLoads of holey double arrays.

Issue 15014020: Elide hole checks on KeyedLoads of holey double arrays. (Closed)

Created:
7 years, 7 months ago by danno

Modified:
7 years, 7 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Elide hole checks on KeyedLoads of holey double arrays Improves NavierStokes by about 5% R=ulan@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14630

Patch Set 3 : Implement missing platforms and add tests #

Total comments: 2

Patch Set 4 : Review feedback #

Patch Set 5 : Merge with ToT #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+559 lines, -21 lines)			Patch
	include/v8.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
	src/arm/lithium-codegen-arm.cc	View	1 2 3 4	1 chunk	+6 lines, -0 lines	0 comments	Download
	src/bootstrapper.cc	View	1 2 3 4	2 chunks	+8 lines, -0 lines	0 comments	Download
	src/code-stubs-hydrogen.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
	src/contexts.h	View	1 2 3 4	3 chunks	+6 lines, -0 lines	0 comments	Download
M	src/heap.cc	View		1 chunk	+2 lines, -9 lines	0 comments	Download
	src/hydrogen.h	View	1	4 chunks	+11 lines, -0 lines	0 comments	Download
	src/hydrogen.cc	View	1 2 3 4	9 chunks	+23 lines, -6 lines	0 comments	Download
	src/hydrogen-instructions.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
	src/hydrogen-instructions.cc	View	1 2 3 4	2 chunks	+22 lines, -1 line	0 comments	Download
	src/ia32/lithium-codegen-ia32.cc	View	1 2 3 4	1 chunk	+6 lines, -0 lines	0 comments	Download
	src/ic.cc	View	1	1 chunk	+8 lines, -1 line	0 comments	Download
	src/isolate.h	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
	src/isolate.cc	View	1 2 3	1 chunk	+38 lines, -0 lines	0 comments	Download
	src/objects.h	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
	src/objects.cc	View	1 2 3	2 chunks	+26 lines, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 2 3 4	1 chunk	+6 lines, -0 lines	0 comments	Download
	test/mjsunit/elide-double-hole-check-1.js	View	1 2 3 4	1 chunk	+52 lines, -0 lines	0 comments	Download
	test/mjsunit/elide-double-hole-check-2.js	View	1 2 3 4	1 chunk	+41 lines, -0 lines	0 comments	Download
	test/mjsunit/elide-double-hole-check-3.js	View	1 2 3 4	1 chunk	+39 lines, -0 lines	0 comments	Download
	test/mjsunit/elide-double-hole-check-4.js	View	1 2 3 4	1 chunk	+39 lines, -0 lines	0 comments	Download
	test/mjsunit/elide-double-hole-check-5.js	View	1 2 3 4	1 chunk	+40 lines, -0 lines	0 comments	Download
	test/mjsunit/elide-double-hole-check-6.js	View	1 2 3 4	1 chunk	+39 lines, -0 lines	0 comments	Download
	test/mjsunit/elide-double-hole-check-7.js	View	1 2 3 4	1 chunk	+40 lines, -0 lines	0 comments	Download
	test/mjsunit/elide-double-hole-check-8.js	View	1 2 3 4	1 chunk	+40 lines, -0 lines	0 comments	Download
	test/mjsunit/elide-double-hole-check-9.js	View	1 2 3 4	1 chunk	+49 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ulan

https://codereview.chromium.org/15014020/diff/6001/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/15014020/diff/6001/src/isolate.cc#newcode2461 src/isolate.cc:2461: Map* root_array_map = Can root_array_map be NULL here?

7 years, 7 months ago (2013-05-10 14:34:25 UTC) #2

danno

Feedback addressed, please take another look https://codereview.chromium.org/15014020/diff/6001/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/15014020/diff/6001/src/isolate.cc#newcode2461 src/isolate.cc:2461: Map* root_array_map = ...

7 years, 7 months ago (2013-05-10 14:40:12 UTC) #3

danno

7 years, 7 months ago (2013-05-13 07:35:45 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 manually as r14630 (presubmit successful).

Expand Messages | Collapse Messages