Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 15014010: Bindings generator should include wtf headers with double quotes (Closed)

Created:
7 years, 7 months ago by do-not-use
Modified:
7 years, 7 months ago
CC:
blink-reviews, haraken, Nate Chapin, eae+blinkwatch, jsbell+bindings_chromium.org, abarth-chromium, lgombos, alancutter (OOO until 2018)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Bindings generator should include wtf headers with double quotes The style scripts complains because the generated code includes wtf headers with <> instead of double quotes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -79 lines) Patch
M Source/bindings/scripts/CodeGeneratorV8.pm View 4 chunks +5 lines, -13 lines 0 comments Download
M Source/bindings/tests/results/V8Float64Array.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8Float64Array.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestActiveDOMObject.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestActiveDOMObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestCallback.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestCustomNamedGetter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestCustomNamedGetter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestEventConstructor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestException.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestException.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestMediaQueryListListener.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestMediaQueryListListener.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestNamedConstructor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestNamedConstructor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestNode.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestObj.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestObj.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/bindings/tests/results/V8TestOverloadedConstructors.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestOverloadedConstructors.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/V8TestSerializedScriptValueInterface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestSerializedScriptValueInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
do-not-use
7 years, 7 months ago (2013-05-08 16:23:19 UTC) #1
arv (Not doing code reviews)
The code LGTM but I don't know enough about imports to know if this is ...
7 years, 7 months ago (2013-05-08 16:41:44 UTC) #2
do-not-use
On 2013/05/08 16:41:44, arv wrote: > The code LGTM but I don't know enough about ...
7 years, 7 months ago (2013-05-08 16:45:12 UTC) #3
abarth-chromium
LGTM2
7 years, 7 months ago (2013-05-08 16:50:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/15014010/1
7 years, 7 months ago (2013-05-08 16:51:27 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-08 17:59:39 UTC) #6
Message was sent while issue was closed.
Change committed as 149958

Powered by Google App Engine
This is Rietveld 408576698