Instant Extended: Use Helvetica Neue

Instant Extended: Use Helvetica Neue

This CL switches the Omnibox, Omnibox decoration, and drop down to use Helvetica Neue.

BUG=237918, 237909, 237905
R=shess@chromium.org, sreeram@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199819

[Scott Hess - ex-Googler, 2013-05-07 18:30:11]

LGTM!  Why not Comic Sans?

https://codereview.chromium.org/15014007/diff/1/chrome/browser/ui/cocoa/locat...
File chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm (right):

https://codereview.chromium.org/15014007/diff/1/chrome/browser/ui/cocoa/locat...
chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm:74: return
[NSFont fontWithName:@"Arial" size:15];
While you're here, why not:

[NSFont fontWithDescriptor:[OmniboxViewMac::GetFieldFont() fontDescriptor]
size:15];

Or even [GetFieldFont() pointSize]-1;

Or add OmniboxViewMac::GetInstantFieldFontName() and have both use that name. 
But I'm not clear that that is actually an improvement over GetFieldFont(),
assuming you really mean literally "The omnibox font, a bit smaller."

[sail, 2013-05-13 16:56:12]

On 2013/05/07 18:30:11, shess wrote:
> LGTM!  Why not Comic Sans?
> 
>
https://codereview.chromium.org/15014007/diff/1/chrome/browser/ui/cocoa/locat...
> File chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm (right):
> 
>
https://codereview.chromium.org/15014007/diff/1/chrome/browser/ui/cocoa/locat...
> chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm:74: return
> [NSFont fontWithName:@"Arial" size:15];
> While you're here, why not:
> 
> [NSFont fontWithDescriptor:[OmniboxViewMac::GetFieldFont() fontDescriptor]
> size:15];
> 
> Or even [GetFieldFont() pointSize]-1;
> 
> Or add OmniboxViewMac::GetInstantFieldFontName() and have both use that name. 
> But I'm not clear that that is actually an improvement over GetFieldFont(),
> assuming you really mean literally "The omnibox font, a bit smaller."

Sorry for the slow response. I think this is a good idea. I'll do it in a
separate CL so that this can be a small mergeable change.

[sail, 2013-05-13 20:18:39]

Switched to

[sail, 2013-05-13 20:19:11]

Switched to Helvetica Neue based on feedback from Cole.  Helvetica Neue doesn't
have the same alignment problems that Helvetica had.

[sail, 2013-05-13 20:19:31]

+sreeram for OWNERS review

[Scott Hess - ex-Googler, 2013-05-13 20:38:29]

LGTM, except for the repetition.

Not sure what alignment problems you're referring to - the ascenders and
descenders look like they reach the same points between Ariel, Helvetica, and
Helvetica Neue, so it probably won't fix that.

Also ... you might consider checking in with someone who tends to complain
vocally about such things before checking this in and having them complain
vocally about it.  If "Helvetica Neue" were the thing for OSX, then I'd have
expected it to be the default, and it isn't.

[sreeram, 2013-05-13 20:43:11]

instant_page rubberstamp lgtm

[sail, 2013-05-13 20:48:13]

On 2013/05/13 20:38:29, shess wrote:
> LGTM, except for the repetition.
> 
> Not sure what alignment problems you're referring to - the ascenders and
> descenders look like they reach the same points between Ariel, Helvetica, and
> Helvetica Neue, so it probably won't fix that.
> 
> Also ... you might consider checking in with someone who tends to complain
> vocally about such things before checking this in and having them complain
> vocally about it.  If "Helvetica Neue" were the thing for OSX, then I'd have
> expected it to be the default, and it isn't.

I sent builds to alcor@ and he seemed happy with things. I'll wait for this to
bake on Canary before merging.

[sail, 2013-05-13 20:49:40]

Committed patchset #3 manually as r199819 (presubmit successful).