Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: third_party/WebKit/Source/core/frame/UseCounter.cpp

Issue 1501393003: Deprecate fetching stylesheets with unsupported type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated tests, converted from fix to deprecation warning Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google, Inc. All rights reserved. 2 * Copyright (C) 2012 Google, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 953 matching lines...) Expand 10 before | Expand all | Expand 10 after
964 964
965 case RTCPeerConnectionCreateAnswerLegacyNoFailureCallback: 965 case RTCPeerConnectionCreateAnswerLegacyNoFailureCallback:
966 return "RTCPeerConnection.CreateAnswer without a failure callback is dep recated. The failure callback will be a required parameter in M50. See https://w ww.chromestatus.com/feature/5663288008376320 for more details"; 966 return "RTCPeerConnection.CreateAnswer without a failure callback is dep recated. The failure callback will be a required parameter in M50. See https://w ww.chromestatus.com/feature/5663288008376320 for more details";
967 967
968 case RTCPeerConnectionCreateOfferLegacyNoFailureCallback: 968 case RTCPeerConnectionCreateOfferLegacyNoFailureCallback:
969 return "RTCPeerConnection.CreateOffer without a failure callback is depr ecated. The failure callback will be a required parameter in M50. See https://ww w.chromestatus.com/feature/5663288008376320 for more details"; 969 return "RTCPeerConnection.CreateOffer without a failure callback is depr ecated. The failure callback will be a required parameter in M50. See https://ww w.chromestatus.com/feature/5663288008376320 for more details";
970 970
971 case ObjectObserve: 971 case ObjectObserve:
972 return willBeRemoved("'Object.observe'", 50, "6147094632988672"); 972 return willBeRemoved("'Object.observe'", 50, "6147094632988672");
973 973
974 case NonCSSStylesheetType:
975 return willBeRemoved("Using stylesheet links with types other than 'text /css'", 50, "XX"); // TODO feature number
976
974 // Features that aren't deprecated don't have a deprecation message. 977 // Features that aren't deprecated don't have a deprecation message.
975 default: 978 default:
976 return String(); 979 return String();
977 } 980 }
978 } 981 }
979 982
980 void UseCounter::count(CSSParserMode cssParserMode, CSSPropertyID feature) 983 void UseCounter::count(CSSParserMode cssParserMode, CSSPropertyID feature)
981 { 984 {
982 ASSERT(feature >= firstCSSProperty); 985 ASSERT(feature >= firstCSSProperty);
983 ASSERT(feature <= lastUnresolvedCSSProperty); 986 ASSERT(feature <= lastUnresolvedCSSProperty);
(...skipping 27 matching lines...) Expand all
1011 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 1014 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
1012 { 1015 {
1013 // FIXME: We may want to handle stylesheets that have multiple owners 1016 // FIXME: We may want to handle stylesheets that have multiple owners
1014 // https://crbug.com/242125 1017 // https://crbug.com/242125
1015 if (sheetContents && sheetContents->hasSingleOwnerNode()) 1018 if (sheetContents && sheetContents->hasSingleOwnerNode())
1016 return getFrom(sheetContents->singleOwnerDocument()); 1019 return getFrom(sheetContents->singleOwnerDocument());
1017 return 0; 1020 return 0;
1018 } 1021 }
1019 1022
1020 } // namespace blink 1023 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698