Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1501373003: X87: [ic] Change CompareIC to handle JSReceiver instead of JSObject. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [ic] Change CompareIC to handle JSReceiver instead of JSObject. port 0ed0878041574382b75d4d549f3ff73afcc72efb (r32642) original commit message: There's no reason to limit the CompareIC to (known) JSObject instances, as all JSReceivers behave the same wrt. abstract and strict equality. So remove this historical limitation and track JSReceivers instead. BUG= Committed: https://crrev.com/1ecb22547749bffb616cb50770280ef4ab456a56 Cr-Commit-Position: refs/heads/master@{#32645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M src/x87/code-stubs-x87.cc View 2 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-07 08:11:28 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-07 08:12:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1501373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1501373003/1
5 years ago (2015-12-07 08:12:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 08:41:11 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-07 08:42:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ecb22547749bffb616cb50770280ef4ab456a56
Cr-Commit-Position: refs/heads/master@{#32645}

Powered by Google App Engine
This is Rietveld 408576698