Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1501343002: Prepare chrome to use the new Mojo EDK by default. (Closed)

Created:
5 years ago by jam
Modified:
5 years ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prepare chrome to use the new Mojo EDK by default. --use-old-edk can override this temporarily. BUG=561803 R=yzshen@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/1b1f6b21bb2b3842a27eb9d8cede60b8cec2ca0e

Patch Set 1 #

Patch Set 2 : fix content tests #

Patch Set 3 : merge #

Patch Set 4 : fixes #

Patch Set 5 : fix remaining tests #

Patch Set 6 : merge #

Patch Set 7 : disable turning on in this cl #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -26 lines) Patch
M base/message_loop/message_loop.cc View 1 2 3 4 1 chunk +6 lines, -1 line 0 comments Download
M content/app/mojo/mojo_init.cc View 1 2 3 4 5 6 1 chunk +9 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/render_view_test.h View 1 3 chunks +8 lines, -2 lines 0 comments Download
M content/public/test/render_view_test.cc View 1 2 3 4 5 6 2 chunks +9 lines, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M content/test/run_all_unittests.cc View 1 2 3 4 5 6 2 chunks +11 lines, -2 lines 2 comments Download
M mojo/edk/embedder/embedder.cc View 1 2 chunks +2 lines, -13 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.cc View 1 2 3 4 1 chunk +9 lines, -3 lines 0 comments Download
M mojo/message_pump/handle_watcher.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M mojo/runner/context.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 21 (14 generated)
jam
see patchset 6 where it's turned on and all the tests pass. I haven't actually ...
5 years ago (2015-12-10 06:22:01 UTC) #8
jam
5 years ago (2015-12-10 17:25:22 UTC) #11
yzshen1
LGTM https://codereview.chromium.org/1501343002/diff/220001/content/test/run_all_unittests.cc File content/test/run_all_unittests.cc (right): https://codereview.chromium.org/1501343002/diff/220001/content/test/run_all_unittests.cc#newcode29 content/test/run_all_unittests.cc:29: base::TestIOThread test_io_thread(base::TestIOThread::kAutoStart); Is line 29 needed if we ...
5 years ago (2015-12-10 17:52:25 UTC) #13
jam
https://codereview.chromium.org/1501343002/diff/220001/content/test/run_all_unittests.cc File content/test/run_all_unittests.cc (right): https://codereview.chromium.org/1501343002/diff/220001/content/test/run_all_unittests.cc#newcode29 content/test/run_all_unittests.cc:29: base::TestIOThread test_io_thread(base::TestIOThread::kAutoStart); On 2015/12/10 17:52:25, yzshen1 wrote: > Is ...
5 years ago (2015-12-10 18:02:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1501343002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1501343002/220001
5 years ago (2015-12-10 18:04:08 UTC) #17
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/1b1f6b21bb2b3842a27eb9d8cede60b8cec2ca0e Cr-Commit-Position: refs/heads/master@{#364399}
5 years ago (2015-12-10 18:11:56 UTC) #19
jam
5 years ago (2015-12-10 18:12:45 UTC) #21
Message was sent while issue was closed.
Committed patchset #7 (id:220001) manually as
1b1f6b21bb2b3842a27eb9d8cede60b8cec2ca0e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698