Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1501323002: X87: Reland of [debugger] do not restart frames that reference new.target for liveedit. (patchset #… (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Reland of [debugger] do not restart frames that reference new.target for liveedit. (patchset #1 id:1 of https://codereview.chromium.org/1493863004/ ) port 15cb3fde7db351138a8ac2c04be8e5d6b122ce97 (r32587) original commit message: Reason for revert: Didn't help... Original issue's description: > Revert of [debugger] do not restart frames that reference new.target for liveedit. (patchset #1 id:1 of https://codereview.chromium.org/1493363002/ ) > > Reason for revert: > [Sheriff] Speculative revert for https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3225 > > Original issue's description: > > [debugger] do not restart frames that reference new.target for liveedit. > > > > R=mstarzinger@chromium.org > > > > Committed: https://crrev.com/6fca870240bdbb07a365189b5eb0c98fa65b3682 > > Cr-Commit-Position: refs/heads/master@{#32572} > > TBR=mstarzinger@chromium.org,yangguo@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/1a61dab34b9849f3f70a42ce69317e22758c53a1 > Cr-Commit-Position: refs/heads/master@{#32582} BUG= Committed: https://crrev.com/1dda6ac253b4b96f4d39eac823c5353ee0171529 Cr-Commit-Position: refs/heads/master@{#32637}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M src/debug/x87/debug-x87.cc View 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-07 03:31:40 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-07 03:48:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1501323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1501323002/1
5 years ago (2015-12-07 03:48:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-07 04:07:33 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-07 04:08:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1dda6ac253b4b96f4d39eac823c5353ee0171529
Cr-Commit-Position: refs/heads/master@{#32637}

Powered by Google App Engine
This is Rietveld 408576698