Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: chrome/browser/blocked_popup_container.h

Issue 150132: First cut at popup blocking for Mac. Remove ifdefs in cross-platform code. Im... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. Use of this 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. Use of this
2 // source code is governed by a BSD-style license that can be found in the 2 // source code is governed by a BSD-style license that can be found in the
3 // LICENSE file. 3 // LICENSE file.
4 4
5 // Defines the public interface for the blocked popup notifications. This 5 // Defines the public interface for the blocked popup notifications. This
6 // interface should only be used by TabContents. Users and subclasses of 6 // interface should only be used by TabContents. Users and subclasses of
7 // TabContents should use the appropriate methods on TabContents to access 7 // TabContents should use the appropriate methods on TabContents to access
8 // information about blocked popups. 8 // information about blocked popups.
9 9
10 #ifndef CHROME_BROWSER_BLOCKED_POPUP_CONTAINER_H_ 10 #ifndef CHROME_BROWSER_BLOCKED_POPUP_CONTAINER_H_
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 // Called by the BlockedPopupContainer that owns us. Destroys the view or 49 // Called by the BlockedPopupContainer that owns us. Destroys the view or
50 // starts a delayed Task to destroy the View at some later time. 50 // starts a delayed Task to destroy the View at some later time.
51 virtual void Destroy() = 0; 51 virtual void Destroy() = 0;
52 }; 52 };
53 53
54 // Takes ownership of TabContents that are unrequested popup windows and 54 // Takes ownership of TabContents that are unrequested popup windows and
55 // presents an interface to the user for launching them. (Or never showing them 55 // presents an interface to the user for launching them. (Or never showing them
56 // again). This class contains all the cross-platform bits that can be used in 56 // again). This class contains all the cross-platform bits that can be used in
57 // all ports. 57 // all ports.
58 // 58 //
59 // TODO(erg): The GTK and Cocoa versions of the view class haven't been written
60 // yet.
61 //
62 // +- BlockedPopupContainer ---+ +- BlockedPopupContainerView -----+ 59 // +- BlockedPopupContainer ---+ +- BlockedPopupContainerView -----+
63 // | All model logic | +--->| Abstract cross platform | 60 // | All model logic | +--->| Abstract cross platform |
64 // | | | | interface | 61 // | | | | interface |
65 // | | | | | 62 // | | | | |
66 // | Owns a platform view_ +----+ | | 63 // | Owns a platform view_ +----+ | |
67 // +---------------------------+ +---------------------------------+ 64 // +---------------------------+ +---------------------------------+
68 // ^ 65 // ^
69 // | 66 // |
70 // +-------------------------------+-----------+ 67 // +-------------------------------+-----------+
71 // | | 68 // | |
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
265 // Information about all popup hosts. 262 // Information about all popup hosts.
266 PopupHosts popup_hosts_; 263 PopupHosts popup_hosts_;
267 264
268 // Our platform specific view. 265 // Our platform specific view.
269 BlockedPopupContainerView* view_; 266 BlockedPopupContainerView* view_;
270 267
271 DISALLOW_IMPLICIT_CONSTRUCTORS(BlockedPopupContainer); 268 DISALLOW_IMPLICIT_CONSTRUCTORS(BlockedPopupContainer);
272 }; 269 };
273 270
274 #endif // CHROME_BROWSER_BLOCKED_POPUP_CONTAINER_H_ 271 #endif // CHROME_BROWSER_BLOCKED_POPUP_CONTAINER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/blocked_popup_container.cc » ('j') | chrome/browser/cocoa/blocked_popup_container_controller.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698