Expose custom property values to getComputedStyle.

Expose custom property values to getComputedStyle.

BUG=465126
Committed: https://crrev.com/690e60bfadaf3a92dd12e47b00c9b018a93506f4
Cr-Commit-Position: refs/heads/master@{#363641}

[shans, 2015-12-07 00:21:43]

shans@chromium.org changed reviewers:
+ leviw@chromium.org, timloh@chromium.org

[Timothy Loh, 2015-12-07 00:48:12]

lgtm

https://codereview.chromium.org/1501313002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
(right):

https://codereview.chromium.org/1501313002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp:2705: //
TODO(leviw): We should have a way to retrive variables here.
should change to TODO to a explainer comment if we're handling it elsewhere

[shans, 2015-12-07 01:06:30]

On 2015/12/07 at 00:48:12, timloh wrote:
> lgtm
> 
>
https://codereview.chromium.org/1501313002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
(right):
> 
>
https://codereview.chromium.org/1501313002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp:2705: //
TODO(leviw): We should have a way to retrive variables here.
> should change to TODO to a explainer comment if we're handling it elsewhere

Done.

[shans, 2015-12-07 01:06:35]

The CQ bit was checked by shans@chromium.org

[commit-bot: I haz the power, 2015-12-07 01:07:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1501313002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1501313002/1

[Timothy Loh, 2015-12-07 01:40:43]

On 2015/12/07 01:07:12, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1501313002/1
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1501313002/1

Did you forget to upload the updated patch?

[Timothy Loh, 2015-12-07 01:40:49]

The CQ bit was unchecked by timloh@chromium.org

[shans, 2015-12-07 02:24:05]

On 2015/12/07 at 01:40:43, timloh wrote:
> On 2015/12/07 01:07:12, commit-bot: I haz the power wrote:
> > CQ is trying da patch. Follow status at
> >  https://chromium-cq-status.appspot.com/patch-status/1501313002/1
> > View timeline at
> >  https://chromium-cq-status.appspot.com/patch-timeline/1501313002/1
> 
> Did you forget to upload the updated patch?

Yes.. or rather I forgot to check it had uploaded.

[shans, 2015-12-07 02:24:30]

The CQ bit was checked by shans@chromium.org

[shans, 2015-12-07 02:24:30]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1501313002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-12-07 02:24:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1501313002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1501313002/20001

[commit-bot: I haz the power, 2015-12-07 03:33:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 03:33:24]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[shans, 2015-12-07 04:37:32]

The CQ bit was checked by shans@chromium.org

[commit-bot: I haz the power, 2015-12-07 04:37:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1501313002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1501313002/20001

[commit-bot: I haz the power, 2015-12-07 05:48:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-07 05:48:45]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[shans, 2015-12-07 23:05:20]

The CQ bit was checked by shans@chromium.org

[commit-bot: I haz the power, 2015-12-07 23:09:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1501313002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1501313002/20001

[commit-bot: I haz the power, 2015-12-08 00:50:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-08 00:50:55]

Description was changed from

==========
Expose custom property values to getComputedStyle.

BUG=465126
==========

to

==========
Expose custom property values to getComputedStyle.

BUG=465126

Committed: https://crrev.com/690e60bfadaf3a92dd12e47b00c9b018a93506f4
Cr-Commit-Position: refs/heads/master@{#363641}
==========

[commit-bot: I haz the power, 2015-12-08 00:50:55]

Patchset 2 (id:??) landed as
https://crrev.com/690e60bfadaf3a92dd12e47b00c9b018a93506f4
Cr-Commit-Position: refs/heads/master@{#363641}