SkPixelSerializer: support indexed pixels

include/core/SkPixelSerializer.h

 /*
  * Copyright 2014 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkPixelSerializer_DEFINED
 #define SkPixelSerializer_DEFINED
 
 #include "SkRefCnt.h"
+#include "SkPixmap.h"
 
 class SkData;
-struct SkImageInfo;
 
 /**
  *  Interface for serializing pixels, e.g. SkBitmaps in an SkPicture.
  */
 class SkPixelSerializer : public SkRefCnt {
 public:
     virtual ~SkPixelSerializer() {}
 
     /**
      *  Call to determine if the client wants to serialize the encoded data. If
      *  false, serialize another version (e.g. the result of encodePixels).
      */
     bool useEncodedData(const void* data, size_t len) {
         return this->onUseEncodedData(data, len);
     }
 
     /**
      *  Call to get the client's version of encoding these pixels. If it
      *  returns NULL, serialize the raw pixels.
      */
     SkData* encodePixels(const SkImageInfo& info, const void* pixels, size_t rowBytes) {

[scroggo, 2015/12/07 15:57:07]

Does anyone call this other than SkWriteBuffer? Or can we go ahead and remove
it?

[hal.canary, 2015/12/07 20:25:01]

done

-        return this->onEncodePixels(info, pixels, rowBytes);
+        return this->encode(SkPixmap(info, pixels, rowBytes, nullptr));
+    }
+
+    /**
+     *  Call to get the client's version of encoding these pixels. If it
+     *  returns NULL, serialize the raw pixels.
+     */
+    SkData* encode(const SkPixmap& pixmap) {
+        SkData* data = this->onEncode(pixmap);
+        return data ? data : this->onEncodePixels(
+                pixmap.info(), pixmap.addr(), pixmap.rowBytes());
     }
 
 protected:
     /**
      *  Return true if you want to serialize the encoded data, false if you want
      *  another version serialized (e.g. the result of encodePixels).
      */
     virtual bool onUseEncodedData(const void* data, size_t len) = 0;
 
     /**
      *  If you want to encode these pixels, return the encoded data as an SkData
      *  Return null if you want to serialize the raw pixels.
      */
-    virtual SkData* onEncodePixels(const SkImageInfo&, const void* pixels, size_t rowBytes) = 0;
+    // NOTE: onEncodePixels() is deprecated and removed in a later CL.

[scroggo, 2015/12/07 15:57:07]

Does Chrome override this? Should we use a macro to conditionally remove it?

[hal.canary, 2015/12/07 20:25:01]

Chrome and only Chrome overrides this.  Macros are usually necessary,  but this
fallback plan doesn't need them.

+    // Subclasses should implement onEncode() instead.  Subclasses
+    // should implement at least one of onEncodePixels() or
+    // onUseEncodedData().
+    virtual SkData* onEncodePixels(const SkImageInfo&,
+                                   const void* /*pixels*/,
+                                   size_t /*rowBytes*/) {
+        return nullptr;
+    }
+    virtual SkData* onEncode(const SkPixmap&) { return nullptr; }
 };
 #endif // SkPixelSerializer_DEFINED