Issue 15013003: Copy llvm-bcanalyzer to build pnacl-bcanalyzer.

Issue 15013003: Copy llvm-bcanalyzer to build pnacl-bcanalyzer. (Closed)

Created:
7 years, 7 months ago by Karl

Modified:
7 years, 7 months ago

Reviewers:
jvoung (off chromium), Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
http://git.chromium.org/native_client/pnacl-llvm.git@master

Visibility:
Public.

More Reviews

Description

Copy llvm-bcanalyzer to build pnacl-bcanalyzer. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3405 R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=a4c38e6

Patch Set 2 : Fix issues brought up by Jan. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+165 lines, -157 lines)			Patch
M	tools/CMakeLists.txt	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/LLVMBuild.txt	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/Makefile	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
A	tools/pnacl-bcanalyzer/CMakeLists.txt	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A +	tools/pnacl-bcanalyzer/LLVMBuild.txt	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	tools/pnacl-bcanalyzer/Makefile	View		2 chunks	+3 lines, -3 lines	0 comments	Download
A +	tools/pnacl-bcanalyzer/pnacl-bcanalyzer.cpp	View	1	16 chunks	+149 lines, -148 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jvoung (off chromium)

lgtm https://codereview.chromium.org/15013003/diff/1/tools/LLVMBuild.txt File tools/LLVMBuild.txt (right): https://codereview.chromium.org/15013003/diff/1/tools/LLVMBuild.txt#newcode19 tools/LLVMBuild.txt:19: subdirectories = bugpoint llc lli llvm-ar llvm-as llvm-bcanalyzer ...

7 years, 7 months ago (2013-05-06 21:43:22 UTC) #2

Karl

Committed patchset #2 manually as ra4c38e6 (presubmit successful).

7 years, 7 months ago (2013-05-06 22:12:37 UTC) #3

Karl

7 years, 7 months ago (2013-05-06 22:16:18 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/15013003/diff/1/tools/LLVMBuild.txt
File tools/LLVMBuild.txt (right):

https://codereview.chromium.org/15013003/diff/1/tools/LLVMBuild.txt#newcode19
tools/LLVMBuild.txt:19: subdirectories = bugpoint llc lli llvm-ar llvm-as
llvm-bcanalyzer llvm-cov llvm-diff llvm-dis llvm-dwarfdump llvm-extract
llvm-jitlistener llvm-link llvm-mc llvm-nm llvm-objdump llvm-prof llvm-ranlib
llvm-rtdyld llvm-size macho-dump opt llvm-mcmarkup pnacl-abicheck pnacl-freeze
pnacl-bcanalyzer
On 2013/05/06 21:43:22, jvoung (cr) wrote:
> keep these semi-sorted?

Did same to CMakeLists.txt and Makefile.

https://codereview.chromium.org/15013003/diff/1/tools/pnacl-bcanalyzer/pnacl-...
File tools/pnacl-bcanalyzer/pnacl-bcanalyzer.cpp (right):

https://codereview.chromium.org/15013003/diff/1/tools/pnacl-bcanalyzer/pnacl-...
tools/pnacl-bcanalyzer/pnacl-bcanalyzer.cpp:11: //  llvm-bcanalyzer [options]   
  - Read frozen PNaCl bitcode from stdin
On 2013/05/06 21:43:22, jvoung (cr) wrote:
> llvm-bcanalyzer -> pnacl-bcanalyzer

Fixed all (3) cases in file.

Expand Messages | Collapse Messages