Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 150125: Send port disconnect events when a frame is unloaded. (Closed)

Created:
11 years, 5 months ago by Matt Perry
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Send port disconnect events when a frame is unloaded. This is the other half of CL http://codereview.chromium.org/125280, which I split into http://codereview.chromium.org/147033 and this CL. BUG=12686 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19686

Patch Set 1 #

Patch Set 2 : from linux #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -42 lines) Patch
M chrome/browser/automation/extension_port_container.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_message_service.h View 5 chunks +20 lines, -17 lines 0 comments Download
M chrome/browser/extensions/extension_message_service.cc View 2 chunks +22 lines, -11 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 2 chunks +11 lines, -6 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/event_bindings.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/renderer_extension_bindings.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/renderer/resources/renderer_extension_bindings.js View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Matt Perry
11 years, 5 months ago (2009-06-30 19:39:07 UTC) #1
Aaron Boodman
11 years, 5 months ago (2009-06-30 22:06:45 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698