Finish mixed_xfermodes GM.

Finish mixed_xfermodes GM.

R=robertphillips@google.com

Committed: https://code.google.com/p/skia/source/detail?r=9137

[robertphillips, 2013-05-14 21:49:37]

lgtm + nits & suggestions

https://codereview.chromium.org/15012026/diff/4001/gm/mixedxfermodes.cpp
File gm/mixedxfermodes.cpp (right):

https://codereview.chromium.org/15012026/diff/4001/gm/mixedxfermodes.cpp#newc...
gm/mixedxfermodes.cpp:21: MixedXfermodesGM() {
Move this into an initialization method to make the ctor lighter weight?

https://codereview.chromium.org/15012026/diff/4001/gm/mixedxfermodes.cpp#newc...
gm/mixedxfermodes.cpp:38: protected:
overrides?

https://codereview.chromium.org/15012026/diff/4001/gm/mixedxfermodes.cpp#newc...
gm/mixedxfermodes.cpp:51: SkIntToScalar(75), SkIntToScalar(105));
x -> drawOption? geometry?

https://codereview.chromium.org/15012026/diff/4001/gm/mixedxfermodes.cpp#newc...
gm/mixedxfermodes.cpp:69: fConvexPath.quadTo(points[3], points[0]);
assert that 'fConvexPath' is indeed convex?

https://codereview.chromium.org/15012026/diff/4001/gm/mixedxfermodes.cpp#newc...
gm/mixedxfermodes.cpp:85: fConcavePath.setFillType(SkPath::kEvenOdd_FillType);
assert that 'fConcavePath' is non-convex?

[bsalomon, 2013-05-15 13:10:20]

https://codereview.chromium.org/15012026/diff/4001/gm/mixedxfermodes.cpp
File gm/mixedxfermodes.cpp (right):

https://codereview.chromium.org/15012026/diff/4001/gm/mixedxfermodes.cpp#newc...
gm/mixedxfermodes.cpp:21: MixedXfermodesGM() {
On 2013/05/14 21:49:37, robertphillips wrote:
> Move this into an initialization method to make the ctor lighter weight?

Done.

https://codereview.chromium.org/15012026/diff/4001/gm/mixedxfermodes.cpp#newc...
gm/mixedxfermodes.cpp:38: protected:
On 2013/05/14 21:49:37, robertphillips wrote:
> overrides?

Done.

https://codereview.chromium.org/15012026/diff/4001/gm/mixedxfermodes.cpp#newc...
gm/mixedxfermodes.cpp:51: SkIntToScalar(75), SkIntToScalar(105));
On 2013/05/14 21:49:37, robertphillips wrote:
> x -> drawOption? geometry?

shape

https://codereview.chromium.org/15012026/diff/4001/gm/mixedxfermodes.cpp#newc...
gm/mixedxfermodes.cpp:69: fConvexPath.quadTo(points[3], points[0]);
On 2013/05/14 21:49:37, robertphillips wrote:
> assert that 'fConvexPath' is indeed convex?

Done.

https://codereview.chromium.org/15012026/diff/4001/gm/mixedxfermodes.cpp#newc...
gm/mixedxfermodes.cpp:85: fConcavePath.setFillType(SkPath::kEvenOdd_FillType);
On 2013/05/14 21:49:37, robertphillips wrote:
> assert that 'fConcavePath' is non-convex?

Done.

[bsalomon, 2013-05-15 13:10:32]

Committed patchset #3 manually as r9137 (presubmit successful).