Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 150113002: drive: Also lock SearchOperation when locking ChangeListLoader (Closed)

Created:
6 years, 10 months ago by hashimoto
Modified:
6 years, 10 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tim+watch_chromium.org, nkostylev+watch_chromium.org, tzik, tfarina, haitaol+watch_chromium.org, nhiroki, oshima+watch_chromium.org, kinuko+watch, rsimha+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

drive: Also lock SearchOperation when locking ChangeListLoader Split LoaderController from ChangeListLoader. SearchOperation obeys LoaderController. BUG=260539 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247932

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -95 lines) Patch
M chrome/browser/chromeos/drive/change_list_loader.h View 5 chunks +32 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/drive/change_list_loader.cc View 5 chunks +48 lines, -35 lines 0 comments Download
M chrome/browser/chromeos/drive/change_list_loader_unittest.cc View 4 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system.cc View 3 chunks +20 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/operation_test_base.h View 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/operation_test_base.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/search_operation.h View 3 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system/search_operation.cc View 4 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/search_operation_unittest.cc View 5 chunks +35 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/sync/entry_update_performer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/sync_client.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/sync_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/sync_client_unittest.cc View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hashimoto
6 years, 10 months ago (2014-01-30 07:12:05 UTC) #1
kinaba
lgtm
6 years, 10 months ago (2014-01-30 07:16:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/150113002/40001
6 years, 10 months ago (2014-01-30 08:45:32 UTC) #3
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 10:50:42 UTC) #4
Message was sent while issue was closed. 
Change committed as 247932

Powered by Google App Engine
This is Rietveld 408576698