Componentize ProfileSyncServiceMock

Componentize ProfileSyncServiceMock

BUG=565305
TBR=rogerta@chromium.org, rdevlin.cronin@chromium.org, bauerb@chromium.org, pkasting@chromium.org, avi@chromium.org, thestig@chromium.org

Committed: https://crrev.com/a6fded27f9fb544e187e4f29b2c5a7edc94dcdc7
Cr-Commit-Position: refs/heads/master@{#364321}

[vabr (Chromium), 2015-12-05 02:09:44]

vabr@chromium.org changed reviewers:
+ pavely@chromium.org

[vabr (Chromium), 2015-12-05 02:09:45]

Hello Pavel,

Could you please also review this change?

Thanks,
Vaclav

[vabr (Chromium), 2015-12-05 02:15:18]

On 2015/12/05 02:09:45, vabr (Chromium) wrote:
> Hello Pavel,
> 
> Could you please also review this change?
> 
> Thanks,
> Vaclav

I forgot to put the mock into test support target, fixing now, will update the
CL soon.

[vabr (Chromium), 2015-12-05 03:23:07]

On 2015/12/05 02:15:18, vabr (Chromium) wrote:
> On 2015/12/05 02:09:45, vabr (Chromium) wrote:
> > Hello Pavel,
> > 
> > Could you please also review this change?
> > 
> > Thanks,
> > Vaclav
> 
> I forgot to put the mock into test support target, fixing now, will update the
> CL soon.

Sorry for the noise. There are both failures in a CL this depends on, and some
linker problems. I will have a look next week and update this CL.

Cheers,
Vaclav

[vabr (Chromium), 2015-12-09 17:24:06]

Description was changed from

==========
Componentize ProfileSyncServiceMock

BUG=565305
==========

to

==========
Componentize ProfileSyncServiceMock

BUG=565305
TBR=rogerta@chromium.org, rdevlin.cronin@chromium.org
==========

[vabr (Chromium), 2015-12-09 17:24:06]

vabr@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org, rogerta@chromium.org

[vabr (Chromium), 2015-12-09 17:26:38]

Description was changed from

==========
Componentize ProfileSyncServiceMock

BUG=565305
TBR=rogerta@chromium.org, rdevlin.cronin@chromium.org
==========

to

==========
Componentize ProfileSyncServiceMock

BUG=565305
TBR=rogerta@chromium.org, rdevlin.cronin@chromium.org, bauerb@chromium.org,
pkasting@chromium.org
==========

[vabr (Chromium), 2015-12-09 17:26:38]

vabr@chromium.org changed reviewers:
+ bauerb@chromium.org, pkasting@chromium.org

[vabr (Chromium), 2015-12-09 17:27:38]

Description was changed from

==========
Componentize ProfileSyncServiceMock

BUG=565305
TBR=rogerta@chromium.org, rdevlin.cronin@chromium.org, bauerb@chromium.org,
pkasting@chromium.org
==========

to

==========
Componentize ProfileSyncServiceMock

BUG=565305
TBR=rogerta@chromium.org, rdevlin.cronin@chromium.org, bauerb@chromium.org,
pkasting@chromium.org, avi@chromium.org
==========

[vabr (Chromium), 2015-12-09 17:27:38]

vabr@chromium.org changed reviewers:
+ avi@chromium.org

[vabr (Chromium), 2015-12-09 17:28:38]

Description was changed from

==========
Componentize ProfileSyncServiceMock

BUG=565305
TBR=rogerta@chromium.org, rdevlin.cronin@chromium.org, bauerb@chromium.org,
pkasting@chromium.org, avi@chromium.org
==========

to

==========
Componentize ProfileSyncServiceMock

BUG=565305
TBR=rogerta@chromium.org, rdevlin.cronin@chromium.org, bauerb@chromium.org,
pkasting@chromium.org, avi@chromium.org, thestig@chromium.org
==========

[vabr (Chromium), 2015-12-09 17:28:39]

vabr@chromium.org changed reviewers:
+ thestig@chromium.org

[vabr (Chromium), 2015-12-09 17:30:37]

Pavel,
Please review this CL.

Lei,
Please review chrome/browser/BUILD.gn.

Also TBRing the following owners for mechanical header path replacements:

avi@: chrome/browser/app_controller_mac_unittest.mm
rogerta@: chrome/browser/signin/signin_tracker_unittest.cc
rdevlin.cronin@: chrome/browser/extensions/api/*
bauerb@: chrome/browser/ui/webui/sync_internals_ui_unittest.cc
pkasting@: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc

Thanks all!
Vaclav

[Avi (use Gerrit), 2015-12-09 17:31:34]

On 2015/12/09 17:30:37, vabr (Chromium) wrote:
> Pavel,
> Please review this CL.
> 
> Lei,
> Please review chrome/browser/BUILD.gn.
> 
> Also TBRing the following owners for mechanical header path replacements:
> 
> avi@: chrome/browser/app_controller_mac_unittest.mm
> rogerta@: chrome/browser/signin/signin_tracker_unittest.cc
> rdevlin.cronin@: chrome/browser/extensions/api/*
> bauerb@: chrome/browser/ui/webui/sync_internals_ui_unittest.cc
> pkasting@: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
> 
> Thanks all!
> Vaclav

chrome/browser/app_controller_mac_unittest.mm LGTM

[Devlin, 2015-12-09 17:32:24]

extensions/ lgtm

[Lei Zhang, 2015-12-09 17:38:12]

chrome/ lgtm

[Roger Tawa OOO till Jul 10th, 2015-12-09 19:18:08]

c/b/s lgtm

[pavely, 2015-12-09 19:41:30]

lgtm

[Peter Kasting, 2015-12-09 22:04:35]

LGTM

[vabr (Chromium), 2015-12-10 07:49:39]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2015-12-10 07:50:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1501123003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1501123003/180001

[commit-bot: I haz the power, 2015-12-10 09:07:05]

Description was changed from

==========
Componentize ProfileSyncServiceMock

BUG=565305
TBR=rogerta@chromium.org, rdevlin.cronin@chromium.org, bauerb@chromium.org,
pkasting@chromium.org, avi@chromium.org, thestig@chromium.org
==========

to

==========
Componentize ProfileSyncServiceMock

BUG=565305
TBR=rogerta@chromium.org, rdevlin.cronin@chromium.org, bauerb@chromium.org,
pkasting@chromium.org, avi@chromium.org, thestig@chromium.org
==========

[commit-bot: I haz the power, 2015-12-10 09:07:07]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-12-10 09:08:06]

Description was changed from

==========
Componentize ProfileSyncServiceMock

BUG=565305
TBR=rogerta@chromium.org, rdevlin.cronin@chromium.org, bauerb@chromium.org,
pkasting@chromium.org, avi@chromium.org, thestig@chromium.org
==========

to

==========
Componentize ProfileSyncServiceMock

BUG=565305
TBR=rogerta@chromium.org, rdevlin.cronin@chromium.org, bauerb@chromium.org,
pkasting@chromium.org, avi@chromium.org, thestig@chromium.org

Committed: https://crrev.com/a6fded27f9fb544e187e4f29b2c5a7edc94dcdc7
Cr-Commit-Position: refs/heads/master@{#364321}
==========

[commit-bot: I haz the power, 2015-12-10 09:08:07]

Patchset 10 (id:??) landed as
https://crrev.com/a6fded27f9fb544e187e4f29b2c5a7edc94dcdc7
Cr-Commit-Position: refs/heads/master@{#364321}