Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 15011008: Don't insert rednant placeholder for text control after deleting (Closed)

Created:
7 years, 7 months ago by yosin_UTC9
Modified:
7 years, 7 months ago
CC:
blink-reviews, eae+blinkwatch, adamk+blink_chromium.org, aurimas (slooooooooow)
Visibility:
Public.

Description

This patch changes behavior of deleting characters from text control not to insert placeholder when text control is empty or ends with newline after deleting. Test: editing/deleting/delete-last-char-in-textarea.html This test covers both 236726 (extra newline) and 236429 (removing needed newline) This patch also changes tests for new behavior according to https://codereview.chromium.org/13532011 BUG=236726

Patch Set 1 : 2013-05-10T19:11 #

Messages

Total messages: 4 (0 generated)
yosin_UTC9
Could you review this patch? Thanks in advance. P.S. This is my first patch for ...
7 years, 7 months ago (2013-05-10 13:49:06 UTC) #1
ojan
There was some duplicate effort here unfortunately. https://codereview.chromium.org/14969020/.
7 years, 7 months ago (2013-05-10 23:38:33 UTC) #2
leviw_travelin_and_unemployed
On 2013/05/10 23:38:33, ojan wrote: > There was some duplicate effort here unfortunately. > https://codereview.chromium.org/14969020/. ...
7 years, 7 months ago (2013-05-10 23:47:40 UTC) #3
yosin_UTC9
7 years, 7 months ago (2013-05-13 04:00:42 UTC) #4
Thanks levi.
https://codereview.chromium.org/14969020/ is better than this patch.

Please include issue 236726 into BUG=.

Powered by Google App Engine
This is Rietveld 408576698