Issue 150107: Reland of r19131, this time with real Math:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150107: Reland of r19131, this time with real Math:... (Closed)

Created:
11 years, 5 months ago by Glen Murphy

Modified:
9 years, 5 months ago

Reviewers:

CC:
chromium-reviews_googlegroups.com, brettw, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Reland of r19131, this time with real Math: PNGDecoder wasn't multiplying the alpha like PNGEncoder was. This lead to color overflow. This intermediate fix makes everything correct, but will make alphaed pixels slightly darker until the user's cache is flushed (I have screenshots of the effect). BUG=13360 TEST=Run base_unittests.exe --gtest_filter=*PNG* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19589

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+79 lines, -9 lines)			Patch
M	base/gfx/png_codec_unittest.cc	View	3 chunks	+47 lines, -0 lines	0 comments	Download
M	base/gfx/png_decoder.cc	View	2 chunks	+18 lines, -3 lines	0 comments	Download
M	chrome/browser/webdata/web_database_unittest.cc	View	2 chunks	+14 lines, -6 lines	0 comments	Download