Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1501053002: The column balancer should ignore things outside the bounds of the row. (Closed)

Created:
5 years ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The column balancer should ignore things outside the bounds of the row. The column balancer examines one row (fragmentainer group) at a time, and it needs to ignore things that happen at hard or soft column breaks in other rows. Do some flow thread coordinate bounds checking to avoid being affected by pagination struts and hard breaks in other rows. BUG=556481 R=leviw@chromium.org Committed: https://crrev.com/904d6b10d8b45a9a3c5933e7252c7d2ee31cb608 Cr-Commit-Position: refs/heads/master@{#364040}

Patch Set 1 #

Patch Set 2 : The top of the first column in a fragmentainer isn't at a column break that belongs to this fragmen… #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -31 lines) Patch
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 1 2 4 chunks +13 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
leviw_travelin_and_unemployed
Once again, LGTM :)
5 years ago (2015-12-09 01:05:29 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1501053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1501053002/20001
5 years ago (2015-12-09 01:35:14 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-09 03:28:23 UTC) #5
mstensho (USE GERRIT)
On 2015/12/09 01:05:29, leviw wrote: > Once again, LGTM :) You unstoppable reviewer, you! I ...
5 years ago (2015-12-09 08:45:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1501053002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1501053002/20001
5 years ago (2015-12-09 08:47:10 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-09 11:35:22 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/904d6b10d8b45a9a3c5933e7252c7d2ee31cb608 Cr-Commit-Position: refs/heads/master@{#364040}
5 years ago (2015-12-09 11:36:06 UTC) #11
leviw_travelin_and_unemployed
On 2015/12/09 at 08:45:12, mstensho wrote: > On 2015/12/09 01:05:29, leviw wrote: > > Once ...
5 years ago (2015-12-09 18:39:24 UTC) #12
mstensho (USE GERRIT)
5 years ago (2015-12-09 18:58:08 UTC) #13
Message was sent while issue was closed.
On 2015/12/09 18:39:24, leviw wrote:
> On 2015/12/09 at 08:45:12, mstensho wrote:
> > On 2015/12/09 01:05:29, leviw wrote:
> > > Once again, LGTM :)
> > 
> > You unstoppable reviewer, you! I hadn't even published this. But yeah, it
was
> ready. :) Thanks.
> 
> I realized I was behind for awhile so I was trying to clear my backlog :)
> 
> It *looked* ready!

You even cleared your frontlog. This was supposed to be your treat for today,
but you already ate it yesterday, so now I don't know what to do. :)

Powered by Google App Engine
This is Rietveld 408576698