Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 150104: Converts BaseView to be non-opaque, which will fix drawing of... (Closed)

Created:
11 years, 5 months ago by rohitrao (ping after 24h)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)
Visibility:
Public.

Description

Converts BaseView to be non-opaque, which will fix drawing of overlapping views, including the findbar and resize widget. Three classes currently inherit from BaseView: TabContentsViewCocoa, RenderWidgetHostViewCocoa, and SadTabView (Mac). BUG=http://crbug.com/10887 BUG=http://crbug.com/13150 TEST=Findbar should never disappear when searching. Resize widget should never disappear. Clicking and dragging in a webpage should not move the window around. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19725

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/browser/cocoa/base_view.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_mac.mm View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
rohitrao (ping after 24h)
11 years, 5 months ago (2009-06-30 15:27:24 UTC) #1
Avi (use Gerrit)
LG
11 years, 5 months ago (2009-06-30 15:29:21 UTC) #2
pink (ping after 24hrs)
LGTM
11 years, 5 months ago (2009-06-30 15:33:43 UTC) #3
pink (ping after 24hrs)
This breaks scrolling. It causes any click to drag the window.
11 years, 5 months ago (2009-06-30 16:24:24 UTC) #4
rohitrao (ping after 24h)
http://developer.apple.com/documentation/Cocoa/Reference/ApplicationKit/Classes/nsview_Class/Reference/NSView.html#//apple_ref/occ/instm/NSView/mouseDownCanMoveWindow is the magic secret. So I think because we have a textured window, any ...
11 years, 5 months ago (2009-06-30 23:04:37 UTC) #5
pink (ping after 24hrs)
LGTM
11 years, 5 months ago (2009-07-01 13:15:09 UTC) #6
Avi (use Gerrit)
11 years, 5 months ago (2009-07-01 14:20:17 UTC) #7
Nice! LGTM

Powered by Google App Engine
This is Rietveld 408576698