Source/core/dom/Element.cpp - Issue 150103007: Use fastGetAttribute in more places - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(385)

My Issues | Starred Open | Closed | All

Unified Diff: Source/core/dom/Element.cpp

Issue 150103007: Use fastGetAttribute in more places (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add more instances Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | Source/core/dom/ShadowTreeStyleSheetCollection.cpp » ('j') | Source/core/html/HTMLImageElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/Element.cpp

diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp

index 14825c8d561016c4acea93202accb04b75c4f1a3..dd2b705676c468dfa9676d3649d49ee7ad587b42 100644

--- a/Source/core/dom/Element.cpp

+++ b/Source/core/dom/Element.cpp

@@ -1269,7 +1269,7 @@ const AtomicString& Element::locateNamespacePrefix(const AtomicString& namespace

KURL Element::baseURI() const

{

- const AtomicString& baseAttribute = getAttribute(baseAttr);

+ const AtomicString& baseAttribute = fastGetAttribute(baseAttr);

KURL base(KURL(), baseAttribute);

if (!base.protocol().isEmpty())

return base;

@@ -2966,7 +2966,7 @@ void Element::webkitRequestPointerLock()

SpellcheckAttributeState Element::spellcheckAttributeState() const

{

- const AtomicString& value = getAttribute(HTMLNames::spellcheckAttr);

+ const AtomicString& value = fastGetAttribute(HTMLNames::spellcheckAttr);

Inactive 2014/02/13 16:03:43 HTMLNames:: is likely not needed.

if (value == nullAtom)

return SpellcheckAttributeDefault;

if (equalIgnoringCase(value, "true") || equalIgnoringCase(value, ""))

« no previous file with comments | « no previous file | Source/core/dom/ShadowTreeStyleSheetCollection.cpp » ('j') | Source/core/html/HTMLImageElement.cpp » ('J')

Powered by Google App Engine

This is Rietveld 408576698