Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Side by Side Diff: Source/core/dom/ShadowTreeStyleSheetCollection.cpp

Issue 150103007: Use fastGetAttribute in more places (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add more instances Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
9 * Copyright (C) 2013 Google Inc. All rights reserved. 9 * Copyright (C) 2013 Google Inc. All rights reserved.
10 * 10 *
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 DocumentOrderedList::iterator end = m_styleSheetCandidateNodes.end(); 50 DocumentOrderedList::iterator end = m_styleSheetCandidateNodes.end();
51 for (DocumentOrderedList::iterator it = begin; it != end; ++it) { 51 for (DocumentOrderedList::iterator it = begin; it != end; ++it) {
52 Node* node = *it; 52 Node* node = *it;
53 StyleSheet* sheet = 0; 53 StyleSheet* sheet = 0;
54 CSSStyleSheet* activeSheet = 0; 54 CSSStyleSheet* activeSheet = 0;
55 55
56 if (!node->isHTMLElement() || !node->hasTagName(styleTag)) 56 if (!node->isHTMLElement() || !node->hasTagName(styleTag))
57 continue; 57 continue;
58 58
59 Element* element = toElement(node); 59 Element* element = toElement(node);
60 AtomicString title = element->getAttribute(titleAttr); 60 const AtomicString& title = element->fastGetAttribute(titleAttr);
61 bool enabledViaScript = false; 61 bool enabledViaScript = false;
62 62
63 sheet = toHTMLStyleElement(node)->sheet(); 63 sheet = toHTMLStyleElement(node)->sheet();
64 if (sheet && !sheet->disabled() && sheet->isCSSStyleSheet()) 64 if (sheet && !sheet->disabled() && sheet->isCSSStyleSheet())
65 activeSheet = toCSSStyleSheet(sheet); 65 activeSheet = toCSSStyleSheet(sheet);
66 66
67 // FIXME: clarify how PREFERRED or ALTERNATE works in shadow trees. 67 // FIXME: clarify how PREFERRED or ALTERNATE works in shadow trees.
68 // Should we set preferred/selected stylesheets name in shadow trees and 68 // Should we set preferred/selected stylesheets name in shadow trees and
69 // use the name in document? 69 // use the name in document?
70 AtomicString rel = element->getAttribute(relAttr); 70 const AtomicString& rel = element->fastGetAttribute(relAttr);
71 if (!enabledViaScript && sheet && !title.isEmpty()) { 71 if (!enabledViaScript && sheet && !title.isEmpty()) {
72 if (engine->preferredStylesheetSetName().isEmpty()) { 72 if (engine->preferredStylesheetSetName().isEmpty()) {
73 if (element->hasLocalName(styleTag) || !rel.contains("alternate" )) { 73 if (element->hasLocalName(styleTag) || !rel.contains("alternate" )) {
74 engine->setPreferredStylesheetSetName(title); 74 engine->setPreferredStylesheetSetName(title);
75 engine->setSelectedStylesheetSetName(title); 75 engine->setSelectedStylesheetSetName(title);
76 } 76 }
77 } 77 }
78 if (title != engine->preferredStylesheetSetName()) 78 if (title != engine->preferredStylesheetSetName())
79 activeSheet = 0; 79 activeSheet = 0;
80 } 80 }
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 toShadowRoot(m_treeScope.rootNode()).host()->setNeedsStyleRecalc(Subtree StyleChange); 115 toShadowRoot(m_treeScope.rootNode()).host()->setNeedsStyleRecalc(Subtree StyleChange);
116 116
117 m_scopingNodesForStyleScoped.didRemoveScopingNodes(); 117 m_scopingNodesForStyleScoped.didRemoveScopingNodes();
118 collection.swap(*this); 118 collection.swap(*this);
119 updateUsesRemUnits(); 119 updateUsesRemUnits();
120 120
121 return change.requiresFullStyleRecalc; 121 return change.requiresFullStyleRecalc;
122 } 122 }
123 123
124 } 124 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698