Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 150103007: Use fastGetAttribute in more places (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use fastGEtAttribute more for titleAttr Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLImageElement.cpp ('k') | Source/core/html/HTMLTableCellElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 787 matching lines...) Expand 10 before | Expand all | Expand 10 after
798 } 798 }
799 799
800 String HTMLInputElement::altText() const 800 String HTMLInputElement::altText() const
801 { 801 {
802 // http://www.w3.org/TR/1998/REC-html40-19980424/appendix/notes.html#altgen 802 // http://www.w3.org/TR/1998/REC-html40-19980424/appendix/notes.html#altgen
803 // also heavily discussed by Hixie on bugzilla 803 // also heavily discussed by Hixie on bugzilla
804 // note this is intentionally different to HTMLImageElement::altText() 804 // note this is intentionally different to HTMLImageElement::altText()
805 String alt = fastGetAttribute(altAttr); 805 String alt = fastGetAttribute(altAttr);
806 // fall back to title attribute 806 // fall back to title attribute
807 if (alt.isNull()) 807 if (alt.isNull())
808 alt = getAttribute(titleAttr); 808 alt = fastGetAttribute(titleAttr);
809 if (alt.isNull()) 809 if (alt.isNull())
810 alt = getAttribute(valueAttr); 810 alt = fastGetAttribute(valueAttr);
811 if (alt.isEmpty()) 811 if (alt.isEmpty())
812 alt = locale().queryString(blink::WebLocalizedString::InputElementAltTex t); 812 alt = locale().queryString(blink::WebLocalizedString::InputElementAltTex t);
813 return alt; 813 return alt;
814 } 814 }
815 815
816 bool HTMLInputElement::canBeSuccessfulSubmitButton() const 816 bool HTMLInputElement::canBeSuccessfulSubmitButton() const
817 { 817 {
818 return m_inputType->canBeSuccessfulSubmitButton(); 818 return m_inputType->canBeSuccessfulSubmitButton();
819 } 819 }
820 820
(...skipping 1051 matching lines...) Expand 10 before | Expand all | Expand 10 after
1872 } 1872 }
1873 1873
1874 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI) 1874 #if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
1875 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer() 1875 PassRefPtr<RenderStyle> HTMLInputElement::customStyleForRenderer()
1876 { 1876 {
1877 return m_inputTypeView->customStyleForRenderer(originalStyleForRenderer()); 1877 return m_inputTypeView->customStyleForRenderer(originalStyleForRenderer());
1878 } 1878 }
1879 #endif 1879 #endif
1880 1880
1881 } // namespace 1881 } // namespace
OLDNEW
« no previous file with comments | « Source/core/html/HTMLImageElement.cpp ('k') | Source/core/html/HTMLTableCellElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698