Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 150103005: Reduce scope (and running time) of sync-repeated-and-caching test. (Closed)

Created:
6 years, 10 months ago by sof
Modified:
6 years, 10 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Reduce scope (and running time) of sync-repeated-and-caching test. Synchronous XMLHttpRequest fetches are slow end-to-end when running LayoutTests, particularly on Windows. The range of requests issued by xmlhttprequest/sync-repeated-and-caching really doesn't have to be that extensive to catch regressions. Hence, reduce scope somewhat. R=tyoshino@chromium.org BUG=327877 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166615

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -55 lines) Patch
M LayoutTests/http/tests/xmlhttprequest/sync-repeated-and-caching.html View 1 chunk +20 lines, -39 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/sync-repeated-and-caching-expected.txt View 1 chunk +6 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sof
Please take a look. Timing for the win_blink_rel trybot run is ~1.2secs for the relevant ...
6 years, 10 months ago (2014-02-06 10:44:24 UTC) #1
tyoshino (SeeGerritForStatus)
OK. You're the original author of the file. As you said, this looks enough for ...
6 years, 10 months ago (2014-02-06 11:25:19 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 10 months ago (2014-02-06 11:31:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/150103005/1
6 years, 10 months ago (2014-02-06 11:31:31 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-06 12:59:20 UTC) #5
Message was sent while issue was closed.
Change committed as 166615

Powered by Google App Engine
This is Rietveld 408576698