sandbox/win/src/target_process.cc - Issue 1501003002: Added protection against mapping image sections between processes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/win/src/target_process.cc

Issue 1501003002: Added protection against mapping image sections between processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes from review Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sandbox/win/src/target_process.cc

diff --git a/sandbox/win/src/target_process.cc b/sandbox/win/src/target_process.cc

index 69dce20a9600ddd1ecfb8bad5964d8e3e555d156..8645e7576435e96ac33a6ef9f9b60943dbd079a8 100644

--- a/sandbox/win/src/target_process.cc

+++ b/sandbox/win/src/target_process.cc

@@ -284,7 +284,7 @@ DWORD TargetProcess::Init(Dispatcher* ipc_dispatcher, void* policy,

return ::GetLastError();

}

- DWORD access = FILE_MAP_READ | FILE_MAP_WRITE;

+ DWORD access = FILE_MAP_READ | FILE_MAP_WRITE | SECTION_QUERY;

HANDLE target_shared_section;

if (!::DuplicateHandle(::GetCurrentProcess(), shared_section_.Get(),

sandbox_process_info_.process_handle(),

« no previous file with comments | « content/common/sandbox_init_win.cc ('k') | no next file » | no next file with comments »