base/memory/shared_memory.h - Issue 1501003002: Added protection against mapping image sections between processes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/shared_memory.h

Issue 1501003002: Added protection against mapping image sections between processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes from review Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/memory/shared_memory.h

diff --git a/base/memory/shared_memory.h b/base/memory/shared_memory.h

index 18416c0fd0703b5c0ab56e5174134e4c69308496..c20fe90fe91e9f1fc71fc06a8895a2d6f83e86be 100644

--- a/base/memory/shared_memory.h

+++ b/base/memory/shared_memory.h

@@ -282,6 +282,9 @@ class BASE_EXPORT SharedMemory {

ShareMode);

#if defined(OS_WIN)

+ // If true indicates this came from an external source so needs extra checks

+ // before being mapped.

+ bool external_section_;

std::wstring name_;

HANDLE mapped_file_;

#elif defined(OS_MACOSX) && !defined(OS_IOS)

« no previous file with comments | « no previous file | base/memory/shared_memory_unittest.cc » ('j') | no next file with comments »