Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1302)

Unified Diff: test/mjsunit/debug-evaluate-shadowed-context.js

Issue 1500933002: [debugger] fix debug-evaluate wrt shadowed context var. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: add TODO Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mjsunit/debug-evaluate-shadowed-context.js
diff --git a/test/mjsunit/debug-evaluate-shadowed-context.js b/test/mjsunit/debug-evaluate-shadowed-context.js
new file mode 100644
index 0000000000000000000000000000000000000000..221efb39d071e07832908c0c67164b66b6860a6d
--- /dev/null
+++ b/test/mjsunit/debug-evaluate-shadowed-context.js
@@ -0,0 +1,82 @@
+// Copyright 2015 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --expose-debug-as debug --no-analyze-environment-liveness
+
+// Test that debug-evaluate only resolves variables that are used by
+// the function inside which we debug-evaluate. This is to avoid
+// incorrect variable resolution when a context-allocated variable is
+// shadowed by a stack-allocated variable.
+
+Debug = debug.Debug
+
+var exception = null;
+function listener(event, exec_state, event_data, data) {
+ if (event != Debug.DebugEvent.Break) return;
+ try {
+ for (var i = 0; i < exec_state.frameCount() - 1; i++) {
+ var frame = exec_state.frame(i);
+ var value;
+ try {
+ value = frame.evaluate("x").value();
+ } catch (e) {
+ value = e.name;
+ }
+ print(frame.sourceLineText());
+ var expected = frame.sourceLineText().match(/\/\/ (.*$)/)[1];
+ assertEquals(String(expected), String(value));
+ }
+ assertEquals("[object global]",
+ String(exec_state.frame(0).evaluate("this").value()));
+ exec_state.frame(0).evaluate("y = 'Y'");
+ exec_state.frame(0).evaluate("a = 'A'");
+ assertThrows(() => exec_state.frame(0).evaluate("z"), ReferenceError);
+ } catch (e) {
+ exception = e;
+ print(e + e.stack);
+ }
+}
+
+Debug.setListener(listener);
+
+var a = "a";
+assertEquals("Y", (function() {
+ var x = 1; // context allocate x
+ (() => x);
+ var y = "y";
+ var z = "z";
+ (function() {
+ var x = 2; // stack allocate shadowing x
+ (function() {
+ y; // access y
+ debugger; // ReferenceError
+ })(); // 2
+ })(); // 1
+ return y;
+})());
+
+assertEquals("A", a);
+a = "a";
+
+assertEquals("Y", (function() {
+ var x = 1; // context allocate x
+ (() => x);
+ var y = "y";
+ var z = "z";
+ (function() {
+ var x = 2; // stack allocate shadowing x
+ (() => {
+ y;
+ a;
+ this; // context allocate receiver
+ debugger; // ReferenceError
+ })(); // 2
+ })(); // 1
+ return y;
+})());
+
+assertEquals("A", a);
+
+Debug.setListener(null);
+assertNull(exception);

Powered by Google App Engine
This is Rietveld 408576698