Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: test/cctest/test-debug.cc

Issue 1500933002: [debugger] fix debug-evaluate wrt shadowed context var. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: add TODO Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-debug.cc
diff --git a/test/cctest/test-debug.cc b/test/cctest/test-debug.cc
index 6c8986b5a7de4328c1fe5df1358860ff22f5cdbd..025e0a72eb026a3cf6a6c244de6080e2e4a0a3d9 100644
--- a/test/cctest/test-debug.cc
+++ b/test/cctest/test-debug.cc
@@ -5422,10 +5422,6 @@ static void ThreadedMessageHandler(const v8::Debug::Message& message) {
void V8Thread::Run() {
const char* source =
"flag = true;\n"
- "function bar( new_value ) {\n"
- " flag = new_value;\n"
- " return \"Return from bar(\" + new_value + \")\";\n"
- "}\n"
"\n"
"function foo() {\n"
" var x = 1;\n"
@@ -5468,10 +5464,11 @@ void DebuggerThread::Run() {
const int kBufSize = 1000;
uint16_t buffer[kBufSize];
- const char* command_1 = "{\"seq\":102,"
+ const char* command_1 =
+ "{\"seq\":102,"
"\"type\":\"request\","
"\"command\":\"evaluate\","
- "\"arguments\":{\"expression\":\"bar(false)\"}}";
+ "\"arguments\":{\"expression\":\"flag = false\"}}";
const char* command_2 = "{\"seq\":103,"
"\"type\":\"request\","
"\"command\":\"continue\"}";

Powered by Google App Engine
This is Rietveld 408576698