Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: src/debug/debug-evaluate.h

Issue 1500933002: [debugger] fix debug-evaluate wrt shadowed context var. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: add TODO Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/debug/debug-evaluate.h
diff --git a/src/debug/debug-evaluate.h b/src/debug/debug-evaluate.h
index d3995d90accdc264f010badab1136e50abeeec58..178e2378817a37e0f1cc6e724d32797e24714dfc 100644
--- a/src/debug/debug-evaluate.h
+++ b/src/debug/debug-evaluate.h
@@ -74,12 +74,28 @@ class DebugEvaluate : public AllStatic {
void MaterializeArgumentsObject(Handle<JSObject> target,
Handle<JSFunction> function);
- Handle<Context> MaterializeReceiver(Handle<Context> target,
- Handle<JSFunction> function);
+ void MaterializeContextChain(Handle<JSObject> target,
+ Handle<Context> context);
+
+ void UpdateContextChainFromMaterializedObject(Handle<JSObject> source,
+ Handle<Context> context);
+
+ Handle<Context> MaterializeReceiver(Handle<Context> parent_context,
+ Handle<Context> lookup_context,
+ Handle<JSFunction> local_function,
+ Handle<JSFunction> global_function,
+ bool this_is_non_local);
+
+ MaybeHandle<Object> LoadFromContext(Handle<Context> context,
+ Handle<String> name);
+
+ void StoreToContext(Handle<Context> context, Handle<String> name,
+ Handle<Object> value);
Handle<SharedFunctionInfo> outer_info_;
Handle<Context> innermost_context_;
List<ContextChainElement> context_chain_;
+ List<Handle<String> > non_locals_;
Isolate* isolate_;
JavaScriptFrame* frame_;
int inlined_jsframe_index_;
« src/ast/scopes.h ('K') | « src/ast/scopes.cc ('k') | src/debug/debug-evaluate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698