Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: test/mjsunit/debug-evaluate-modify-catch-block-scope.js

Issue 1500933002: [debugger] fix debug-evaluate wrt shadowed context var. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: add TODO Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Flags: --expose-debug-as debug 5 // Flags: --expose-debug-as debug
6 6
7 function f() { 7 Debug = debug.Debug
8 1;
9 2;
10 3;
11 }
12 8
13 var Debug = debug.Debug;
14 var exception = null; 9 var exception = null;
15 var breaks = [];
16
17 function listener(event, exec_state, event_data, data) { 10 function listener(event, exec_state, event_data, data) {
18 if (event != Debug.DebugEvent.Break) return; 11 if (event != Debug.DebugEvent.Break) return;
19 try { 12 try {
20 Debug.debuggerFlags().breakPointsActive.setValue(false); 13 exec_state.frame(0).evaluate("bar()");
21 breaks.push(exec_state.frame().sourceLineText().trimLeft());
22 exec_state.prepareStep(Debug.StepAction.StepIn, 1);
23 } catch (e) { 14 } catch (e) {
24 exception = e; 15 exception = e;
16 print(e + e.stack);
25 } 17 }
26 } 18 }
27 19
28 Debug.setListener(listener); 20 Debug.setListener(listener);
29 Debug.setBreakPoint(f, 0, 0);
30 21
31 f(); 22 (function() {
23 "use strict";
24 try {
25 throw 1;
26 } catch (e) {
27 let a = 1;
28 function bar() {
29 a = 2; // this has no effect, when called from debug-eval
30 e = 2; // this has no effect, when called from debug-eval.
31 }
32 debugger;
33 assertEquals(1, a);
34 assertEquals(1, e);
35 }
36 })();
32 37
33 Debug.setListener(null); 38 Debug.setListener(null);
34 Debug.debuggerFlags().breakPointsActive.setValue(true);
35
36 assertNull(exception); 39 assertNull(exception);
37 assertEquals(breaks, ["1;", "2;", "3;", "}", "Debug.setListener(null);"]);
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698