sandbox/win/src/win_utils.cc - Issue 150093006: Include trailing '\' when iterating over path in reparse points search.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/win/src/win_utils.cc

Issue 150093006: Include trailing '\' when iterating over path in reparse points search. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Skip root dir when testing for reparse points in path. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sandbox/win/src/win_utils.cc

diff --git a/sandbox/win/src/win_utils.cc b/sandbox/win/src/win_utils.cc

index 53a12a4f292d4da12435fd20ad3858f57feaddf5..1637a193407a0ecf95b56661c6cbf16af771f4f6 100644

--- a/sandbox/win/src/win_utils.cc

+++ b/sandbox/win/src/win_utils.cc

@@ -114,7 +114,7 @@ DWORD IsReparsePoint(const base::string16& full_path, bool* result) {

}

last_pos = path.rfind(L'\\');

- } while (last_pos != base::string16::npos);

+ } while (last_pos > 2); // Skip root dir

rvargas (doing something else) 2014/02/06 18:12:07 Tiny nit: period at the end.

*result = false;

return ERROR_SUCCESS;

« no previous file with comments | « no previous file | no next file » | no next file with comments »