Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Unified Diff: sandbox/win/src/win_utils.cc

Issue 150093006: Include trailing '\' when iterating over path in reparse points search. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/win/src/win_utils.cc
diff --git a/sandbox/win/src/win_utils.cc b/sandbox/win/src/win_utils.cc
index 53a12a4f292d4da12435fd20ad3858f57feaddf5..4445246c997702266fbda430b59626bd2f5e0146 100644
--- a/sandbox/win/src/win_utils.cc
+++ b/sandbox/win/src/win_utils.cc
@@ -95,7 +95,8 @@ DWORD IsReparsePoint(const base::string16& full_path, bool* result) {
base::string16::size_type last_pos = base::string16::npos;
do {
- path = path.substr(0, last_pos);
+ if (last_pos != base::string16::npos)
+ path = path.substr(0, last_pos + 1);
DWORD attributes = ::GetFileAttributes(path.c_str());
if (INVALID_FILE_ATTRIBUTES == attributes) {
@@ -113,6 +114,7 @@ DWORD IsReparsePoint(const base::string16& full_path, bool* result) {
return ERROR_SUCCESS;
}
+ path = path.substr(0, last_pos);
last_pos = path.rfind(L'\\');
} while (last_pos != base::string16::npos);
rvargas (doing something else) 2014/02/03 23:09:24 Looks like we should instead break the loop when w
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698