chrome/common/extensions/docs/server2/file_system.py - Issue 15009006: Docserver: refactor Servlet, ObjectStore, and ServerInstance architecture to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/file_system.py

Issue 15009006: Docserver: refactor Servlet, ObjectStore, and ServerInstance architecture to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix example zipper Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/docs/server2/cron_servlet.py ('K') | « chrome/common/extensions/docs/server2/fake_fetchers.py ('k') | chrome/common/extensions/docs/server2/github_file_system.py » ('j') | chrome/common/extensions/docs/server2/handler.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/file_system.py

diff --git a/chrome/common/extensions/docs/server2/file_system.py b/chrome/common/extensions/docs/server2/file_system.py

index 0450a063271327a7ddacae833267cc56e4363581..ec0a08912edc11cdf611e271d230178e675987f1 100644

--- a/chrome/common/extensions/docs/server2/file_system.py

+++ b/chrome/common/extensions/docs/server2/file_system.py

@@ -66,9 +66,11 @@ class FileSystem(object):

'''

raise NotImplementedError()

- @classmethod

- def GetName(cls):

- '''The type of the file system, exposed for caching classes to namespace

- their caches. It is unlikely that this needs to be overridden.

+ def GetIdentity(self):

+ '''The identity of the file system, exposed for caching classes to

+ namespace their caches. The will usually depend on the configuration of that

cduvall 2013/05/08 03:09:14 The -> This

not at google - send to devlin 2013/05/08 18:26:19 Done.

+ file system - e.g. a LocalFileSystem with a base path of /var is different

+ to that of a SubversionFileSystem with a base path of /bar, is different to

+ a LocalFileSystem with a base path of /usr.

'''

- return cls.__name__

+ raise NotImplementedError()