Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1500873002: Implement sequential focus navigation for OOPIF. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup and test fix Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 0db8f24e912c0fabcddef7f30b37c8e696090b5a..eedcf80180dc0c91e7f2d518fa17efc2150dd2ba 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -1242,6 +1242,7 @@ bool RenderFrameImpl::OnMessageReceived(const IPC::Message& msg) {
IPC_MESSAGE_HANDLER(FrameMsg_DidUpdateSandboxFlags, OnDidUpdateSandboxFlags)
IPC_MESSAGE_HANDLER(FrameMsg_SetFrameOwnerProperties,
OnSetFrameOwnerProperties)
+ IPC_MESSAGE_HANDLER(FrameMsg_AdvanceFocus, OnAdvanceFocus)
IPC_MESSAGE_HANDLER(FrameMsg_SetTextTrackSettings,
OnTextTrackSettingsChanged)
IPC_MESSAGE_HANDLER(FrameMsg_PostMessageEvent, OnPostMessageEvent)
@@ -1800,6 +1801,15 @@ void RenderFrameImpl::OnSetFrameOwnerProperties(
frame_->setFrameOwnerProperties(frame_owner_properties);
}
+void RenderFrameImpl::OnAdvanceFocus(blink::WebFocusType type,
+ int source_routing_id) {
+ RenderFrameProxy* source_frame =
+ RenderFrameProxy::FromRoutingID(source_routing_id);
+
+ render_view_->webview()->advanceFocusAcrossFrames(
+ type, source_frame->web_frame(), frame_);
Charlie Reis 2015/12/04 21:44:50 Should we null check source_frame?
alexmos 2015/12/04 22:21:18 Done. I suppose this is possible with race condit
Charlie Reis 2015/12/04 22:27:04 Acknowledged.
+}
+
void RenderFrameImpl::OnTextTrackSettingsChanged(
const FrameMsg_TextTrackSettings_Params& params) {
DCHECK(!frame_->parent());

Powered by Google App Engine
This is Rietveld 408576698