Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Unified Diff: content/browser/frame_host/render_frame_proxy_host.cc

Issue 1500873002: Implement sequential focus navigation for OOPIF. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup and test fix Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_proxy_host.cc
diff --git a/content/browser/frame_host/render_frame_proxy_host.cc b/content/browser/frame_host/render_frame_proxy_host.cc
index c921e04697adbfb4625e7d50bbb7538cdfc7b791..1df93b86b8082a410241833bad83b16c49858923 100644
--- a/content/browser/frame_host/render_frame_proxy_host.cc
+++ b/content/browser/frame_host/render_frame_proxy_host.cc
@@ -146,6 +146,7 @@ bool RenderFrameProxyHost::OnMessageReceived(const IPC::Message& msg) {
IPC_MESSAGE_HANDLER(FrameHostMsg_OpenURL, OnOpenURL)
IPC_MESSAGE_HANDLER(FrameHostMsg_RouteMessageEvent, OnRouteMessageEvent)
IPC_MESSAGE_HANDLER(FrameHostMsg_DidChangeOpener, OnDidChangeOpener)
+ IPC_MESSAGE_HANDLER(FrameHostMsg_AdvanceFocus, OnAdvanceFocus)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
return handled;
@@ -325,4 +326,25 @@ void RenderFrameProxyHost::OnDidChangeOpener(int32 opener_routing_id) {
GetSiteInstance());
}
+void RenderFrameProxyHost::OnAdvanceFocus(blink::WebFocusType type,
+ int32 source_routing_id) {
dcheng 2015/12/04 23:11:01 Nit: int32_t
alexmos 2015/12/05 00:07:45 Done.
+ RenderFrameHostImpl* target_rfh =
+ frame_tree_node_->render_manager()->current_frame_host();
+
+ RenderFrameHostImpl* source_rfh =
Charlie Reis 2015/12/04 21:44:50 nit: Add comment: Translate the source RenderFrame
alexmos 2015/12/04 22:21:17 Done.
+ RenderFrameHostImpl::FromID(GetProcess()->GetID(), source_routing_id);
+ int source_proxy_routing_id = MSG_ROUTING_NONE;
+ if (source_rfh) {
+ RenderFrameProxyHost* source_proxy =
+ source_rfh->frame_tree_node()
+ ->render_manager()
+ ->GetRenderFrameProxyHost(target_rfh->GetSiteInstance());
+ if (source_proxy)
+ source_proxy_routing_id = source_proxy->GetRoutingID();
+ }
+
+ target_rfh->Send(new FrameMsg_AdvanceFocus(target_rfh->GetRoutingID(), type,
+ source_proxy_routing_id));
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698