Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1584)

Unified Diff: content/browser/site_per_process_browsertest.cc

Issue 1500873002: Implement sequential focus navigation for OOPIF. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Daniel's comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/site_per_process_browsertest.cc
diff --git a/content/browser/site_per_process_browsertest.cc b/content/browser/site_per_process_browsertest.cc
index 007c6cd1a724abf7b2f7e11ea854ef7dfd2f894e..cd46ef8f79d3283891133379d3fa80efdb263433 100644
--- a/content/browser/site_per_process_browsertest.cc
+++ b/content/browser/site_per_process_browsertest.cc
@@ -4069,6 +4069,91 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest,
EXPECT_EQ("FOO", result);
}
+// Ensure that sequential focus navigation (advancing focused elements with
+// <tab> and <shift-tab>) works across cross-process subframes.
+// The test sets up six inputs fields in a page with two cross-process
+// subframes:
+// child1 child2
+// /------------\ /------------\.
+// | 2. <input> | | 4. <input> |
+// 1. <input> | 3. <input> | | 5. <input> | 6. <input>
+// \------------/ \------------/.
+//
+// The test then presses <tab> six times to cycle through focused elements 1-6.
+// The test then repeats this with <shift-tab> to cycle in reverse order.
+IN_PROC_BROWSER_TEST_F(SitePerProcessBrowserTest, SequentialFocusNavigation) {
+ GURL main_url(embedded_test_server()->GetURL(
+ "a.com", "/cross_site_iframe_factory.html?a(b,c)"));
+ EXPECT_TRUE(NavigateToURL(shell(), main_url));
+
+ WebContents* contents = shell()->web_contents();
+ FrameTreeNode* root =
+ static_cast<WebContentsImpl*>(contents)->GetFrameTree()->root();
+
+ // Assign a name to each frame. This will be sent along in test messages
+ // from focus events.
+ EXPECT_TRUE(ExecuteScript(root->current_frame_host(),
+ "window.name = 'root';"));
+ EXPECT_TRUE(ExecuteScript(root->child_at(0)->current_frame_host(),
+ "window.name = 'child1';"));
+ EXPECT_TRUE(ExecuteScript(root->child_at(1)->current_frame_host(),
+ "window.name = 'child2';"));
+
+ // This script will insert two <input> fields in the document, one at the
+ // beginning and one at the end. For root frame, this means that we will
+ // have an <input>, then two <iframe> elements, then another <input>.
+ std::string script =
+ "function onFocus(e) {"
+ " domAutomationController.setAutomationId(0);"
+ " domAutomationController.send(window.name + '-focused-' + e.target.id);"
+ "}"
+ "var input1 = document.createElement('input');"
+ "input1.id = 'input1';"
+ "var input2 = document.createElement('input');"
+ "input2.id = 'input2';"
+ "document.body.insertBefore(input1, document.body.firstChild);"
+ "document.body.appendChild(input2);"
+ "input1.addEventListener('focus', onFocus, false);"
+ "input2.addEventListener('focus', onFocus, false);";
+
+ // Add two input fields to each of the three frames.
+ EXPECT_TRUE(ExecuteScript(root->current_frame_host(), script));
+ EXPECT_TRUE(ExecuteScript(root->child_at(0)->current_frame_host(), script));
+ EXPECT_TRUE(ExecuteScript(root->child_at(1)->current_frame_host(), script));
+
+ // Helper to simulate a tab press and wait for a focus message.
+ auto press_tab_and_wait_for_message = [contents](bool reverse) {
+ DOMMessageQueue msg_queue;
+ std::string reply;
+ SimulateKeyPress(contents, ui::VKEY_TAB, false, reverse /* shift */, false,
+ false);
+ EXPECT_TRUE(msg_queue.WaitForMessage(&reply));
+ return reply;
+ };
+
+ // Press <tab> six times to focus each of the <input> elements in turn.
+ EXPECT_EQ("\"root-focused-input1\"", press_tab_and_wait_for_message(false));
+ EXPECT_EQ(root, root->frame_tree()->GetFocusedFrame());
+ EXPECT_EQ("\"child1-focused-input1\"", press_tab_and_wait_for_message(false));
+ EXPECT_EQ(root->child_at(0), root->frame_tree()->GetFocusedFrame());
+ EXPECT_EQ("\"child1-focused-input2\"", press_tab_and_wait_for_message(false));
+ EXPECT_EQ("\"child2-focused-input1\"", press_tab_and_wait_for_message(false));
+ EXPECT_EQ(root->child_at(1), root->frame_tree()->GetFocusedFrame());
+ EXPECT_EQ("\"child2-focused-input2\"", press_tab_and_wait_for_message(false));
+ EXPECT_EQ("\"root-focused-input2\"", press_tab_and_wait_for_message(false));
+ EXPECT_EQ(root, root->frame_tree()->GetFocusedFrame());
+
+ // Now, press <shift-tab> to navigate focus in the reverse direction.
+ EXPECT_EQ("\"child2-focused-input2\"", press_tab_and_wait_for_message(true));
+ EXPECT_EQ(root->child_at(1), root->frame_tree()->GetFocusedFrame());
+ EXPECT_EQ("\"child2-focused-input1\"", press_tab_and_wait_for_message(true));
+ EXPECT_EQ("\"child1-focused-input2\"", press_tab_and_wait_for_message(true));
+ EXPECT_EQ(root->child_at(0), root->frame_tree()->GetFocusedFrame());
+ EXPECT_EQ("\"child1-focused-input1\"", press_tab_and_wait_for_message(true));
+ EXPECT_EQ("\"root-focused-input1\"", press_tab_and_wait_for_message(true));
+ EXPECT_EQ(root, root->frame_tree()->GetFocusedFrame());
+}
+
// A WebContentsDelegate to capture ContextMenu creation events.
class ContextMenuObserverDelegate : public WebContentsDelegate {
public:
« no previous file with comments | « content/browser/frame_host/render_frame_proxy_host.cc ('k') | content/common/browser_plugin/browser_plugin_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698