Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Unified Diff: chrome/browser/renderer_host/browser_render_process_host.cc

Issue 150087: Create A/B test of SDCH... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/dns_master_unittest.cc ('k') | chrome/common/chrome_switches.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/browser_render_process_host.cc
===================================================================
--- chrome/browser/renderer_host/browser_render_process_host.cc (revision 19579)
+++ chrome/browser/renderer_host/browser_render_process_host.cc (working copy)
@@ -311,15 +311,14 @@
const std::string locale = g_browser_process->GetApplicationLocale();
cmd_line.AppendSwitchWithValue(switches::kLang, ASCIIToWide(locale));
- // If we run a FieldTrial that we want to pass to the renderer, this is where
- // the SINGULAR trial name and value should be specified. Note that only one
- // such flag should be passed/set in the renderer command line.
-
- // Today we're watching the impact of DNS on some page load times.
- FieldTrial* field_trial = FieldTrialList::Find("DnsImpact");
- if (field_trial && (field_trial->group() != FieldTrial::kNotParticipating))
+ // If we run FieldTrials, we want to pass to their state to the renderer so
+ // that it can act in accordance with each state, or record histograms
+ // relating to the FieldTrial states.
+ std::string field_trial_states;
+ FieldTrialList::StatesToString(&field_trial_states);
+ if (!field_trial_states.empty())
cmd_line.AppendSwitchWithValue(switches::kForceFieldTestNameAndValue,
- ASCIIToWide(field_trial->MakePersistentString()));
+ ASCIIToWide(field_trial_states));
#if defined(OS_POSIX)
const bool has_cmd_prefix =
« no previous file with comments | « chrome/browser/net/dns_master_unittest.cc ('k') | chrome/common/chrome_switches.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698