[Sync] Ensure all values of SyncProtocolErrorType are handled in ShouldRequestEarlyExit

[Sync] Ensure all values of SyncProtocolErrorType are handled in ShouldRequestEarlyExit

The issue is that in ShouldRequestEarlyExit (sync_scheduler_impl.cc)
switch statement doesn't explicitly handle all SyncProtocolErrorType
values and therefore they are handled by default: and cause NOTREACHED().

In the current code two values that are not handled are
NON_RETRIABLE_ERROR and PARTIAL_FAILURE.

The change is to remove default handler from switch so that adding new
error type without handling it explicitly would cause compiler error.

In addition I removed NON_RETRIABLE_ERROR as it seems to be not used.

BUG=565102
R=zea@chromium.org

Committed: https://crrev.com/ae33a61d1c888132fdd6bf4fa9d47074d06edb87
Cr-Commit-Position: refs/heads/master@{#363283}

[Nicolas Zea, 2015-12-03 22:10:05]

lgtm

[pavely, 2015-12-03 22:10:18]

The CQ bit was checked by pavely@chromium.org

[commit-bot: I haz the power, 2015-12-03 22:25:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1500803002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1500803002/1

[commit-bot: I haz the power, 2015-12-04 00:08:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 00:08:51]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)

[pavely, 2015-12-04 00:17:16]

The CQ bit was checked by pavely@chromium.org

[commit-bot: I haz the power, 2015-12-04 00:18:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1500803002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1500803002/1

[commit-bot: I haz the power, 2015-12-04 00:39:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 00:39:34]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)

[pavely, 2015-12-04 19:13:56]

The CQ bit was checked by pavely@chromium.org

[pavely, 2015-12-04 19:13:56]

The patchset sent to the CQ was uploaded after l-g-t-m from zea@chromium.org
Link to the patchset: https://codereview.chromium.org/1500803002/#ps20001
(title: "Fix windows build")

[commit-bot: I haz the power, 2015-12-04 19:15:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1500803002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1500803002/20001

[commit-bot: I haz the power, 2015-12-04 20:20:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-04 20:21:40]

Description was changed from

==========
[Sync] Ensure all values of SyncProtocolErrorType are handled in
ShouldRequestEarlyExit

The issue is that in ShouldRequestEarlyExit (sync_scheduler_impl.cc)
switch statement doesn't explicitly handle all SyncProtocolErrorType
values and therefore they are handled by default: and cause NOTREACHED().

In the current code two values that are not handled are
NON_RETRIABLE_ERROR and PARTIAL_FAILURE.

The change is to remove default handler from switch so that adding new
error type without handling it explicitly would cause compiler error.

In addition I removed NON_RETRIABLE_ERROR as it seems to be not used.

BUG=565102
R=zea@chromium.org
==========

to

==========
[Sync] Ensure all values of SyncProtocolErrorType are handled in
ShouldRequestEarlyExit

The issue is that in ShouldRequestEarlyExit (sync_scheduler_impl.cc)
switch statement doesn't explicitly handle all SyncProtocolErrorType
values and therefore they are handled by default: and cause NOTREACHED().

In the current code two values that are not handled are
NON_RETRIABLE_ERROR and PARTIAL_FAILURE.

The change is to remove default handler from switch so that adding new
error type without handling it explicitly would cause compiler error.

In addition I removed NON_RETRIABLE_ERROR as it seems to be not used.

BUG=565102
R=zea@chromium.org

Committed: https://crrev.com/ae33a61d1c888132fdd6bf4fa9d47074d06edb87
Cr-Commit-Position: refs/heads/master@{#363283}
==========

[commit-bot: I haz the power, 2015-12-04 20:21:40]

Patchset 2 (id:??) landed as
https://crrev.com/ae33a61d1c888132fdd6bf4fa9d47074d06edb87
Cr-Commit-Position: refs/heads/master@{#363283}