Add device port unmapping support to forwarder2.

tools/android/forwarder2/host_forwarder_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <errno.h>
 #include <signal.h>
 #include <unistd.h>
 
+#include <cmath>
 #include <cstdio>
 #include <cstring>
 #include <string>
+#include <utility>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
+#include "base/hash_tables.h"
 #include "base/logging.h"
+#include "base/memory/linked_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/posix/eintr_wrapper.h"
 #include "base/safe_strerror_posix.h"
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_split.h"
 #include "tools/android/forwarder2/common.h"
 #include "tools/android/forwarder2/daemon.h"
@@ skipping 86 matching lines @@
     DCHECK(!g_notifier);
     g_notifier = new PipeNotifier();
     signal(SIGTERM, KillHandler);
     signal(SIGINT, KillHandler);
   }
 
   virtual void OnClientConnected(scoped_ptr<Socket> client_socket) OVERRIDE {
     char buf[kBufSize];
     const int bytes_read = client_socket->Read(buf, sizeof(buf));
     if (bytes_read <= 0) {
-      if (client_socket->exited())
+      if (client_socket->DidReceiveEvent())
         return;
       PError("Read()");
       has_failed_ = true;
       return;
     }
     const std::string command(buf, bytes_read);
     int adb_port = 0;
     int device_port = 0;
     std::string forward_to_host;
     int forward_to_port = 0;
     const bool succeeded = ParseForwardCommand(
         command, &adb_port, &device_port, &forward_to_host, &forward_to_port);
     if (!succeeded) {
       has_failed_ = true;
-      client_socket->WriteString(
-          base::StringPrintf("ERROR: Could not parse forward command '%s'",
-                             command.c_str()));
+      const std::string msg = base::StringPrintf(
+          "ERROR: Could not parse forward command '%s'", command.c_str());
+      SendMessage(msg, client_socket.get());
       return;
     }
+    if (device_port < 0) {
+      // Remove the previously created host controller.
+      const std::string controller_key = MakeHostControllerMapKey(
+          adb_port, std::abs(device_port));

[digit1, 2013/05/15 10:13:46]

I believe -device_port might work as well since you know the value is negative
here.

[Philippe, 2013/05/15 11:40:50]

Done.

+      const HostControllerMap::size_type removed_elements = controllers_.erase(
+          controller_key);
+      SendMessage(
+          !removed_elements ? "ERROR: could not unmap port" : "OK",
+          client_socket.get());
+      return;
+    }
+    // Create a new host controller.
     scoped_ptr<HostController> host_controller(
         new HostController(device_port, forward_to_host, forward_to_port,
                            adb_port, GetExitNotifierFD()));
     if (!host_controller->Connect()) {
       has_failed_ = true;
-      client_socket->WriteString("ERROR: Connection to device failed.");
+      SendMessage("ERROR: Connection to device failed.", client_socket.get());
       return;
     }
     // Get the current allocated port.
     device_port = host_controller->device_port();
     LOG(INFO) << "Forwarding device port " << device_port << " to host "
               << forward_to_host << ":" << forward_to_port;
-    if (!client_socket->WriteString(
-        base::StringPrintf("%d:%d", device_port, forward_to_port))) {
-      has_failed_ = true;
+    const std::string msg = base::StringPrintf(
+        "%d:%d", device_port, forward_to_port);
+    if (!SendMessage(msg, client_socket.get()))
       return;
-    }
     host_controller->Start();
-    controllers_.push_back(host_controller.release());
+    const std::string controller_key = MakeHostControllerMapKey(
+        adb_port, device_port);
+    controllers_.insert(
+        std::make_pair(controller_key,
+                       linked_ptr<HostController>(host_controller.release())));
   }
 
   virtual void OnServerExited() OVERRIDE {
-    for (int i = 0; i < controllers_.size(); ++i)
-      controllers_[i]->Join();
+    for (HostControllerMap::iterator it = controllers_.begin();
+         it != controllers_.end(); ++it) {
+      linked_ptr<HostController> host_controller = it->second;
+      host_controller->Join();
+    }
     if (controllers_.size() == 0) {
       LOG(ERROR) << "No forwarder servers could be started. Exiting.";
       has_failed_ = true;
     }
   }
 
  private:
-  ScopedVector<HostController> controllers_;
+  typedef base::hash_map<
+      std::string, linked_ptr<HostController> > HostControllerMap;
+
+  static std::string MakeHostControllerMapKey(int adb_port, int device_port) {
+    return base::StringPrintf("%d:%d", adb_port, device_port);
+  }
+
+  bool SendMessage(const std::string& msg, Socket* client_socket) {
+    bool result = client_socket->WriteString(msg);
+    DCHECK(result);
+    if (!result)
+      has_failed_ = true;
+    return result;
+  }
+
+  HostControllerMap controllers_;
   bool has_failed_;
 
   DISALLOW_COPY_AND_ASSIGN(ServerDelegate);
 };
 
 class ClientDelegate : public Daemon::ClientDelegate {
  public:
   ClientDelegate(const std::string& forward_command)
       : forward_command_(forward_command),
         has_failed_(false) {
@@ skipping 20 matching lines @@
     printf("%s\n", buf);
   }
 
  private:
   const std::string forward_command_;
   bool has_failed_;
 };
 
 void PrintUsage(const char* program_name) {
   LOG(ERROR) << program_name << " adb_port:from_port:to_port:to_host\n"
-      "<adb port> is the TCP port Adb is configured to forward to.";
+      "<adb port> is the TCP port Adb is configured to forward to.\n"
+      "Note that <from_port> can be unmapped by making it negative.";
 }
 
 int RunHostForwarder(int argc, char** argv) {
   if (!CommandLine::Init(argc, argv)) {
     LOG(ERROR) << "Could not initialize command line";
     return 1;
   }
   const CommandLine& command_line = *CommandLine::ForCurrentProcess();
   const char* command = NULL;
   int adb_port = 0;
@@ skipping 26 matching lines @@
 
   return client_delegate.has_failed() || daemon_delegate.has_failed();
 }
 
 }  // namespace
 }  // namespace forwarder2
 
 int main(int argc, char** argv) {
   return forwarder2::RunHostForwarder(argc, argv);
 }