pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart - Issue 1500793003: rework ArgListContributor to use new task model

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

Issue 1500793003: rework ArgListContributor to use new task model (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: merge Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart ('k') | pkg/analysis_server/test/services/completion/arglist_contributor_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

index e9aa7cba4c6ccea2097d47a39f6d35469b673f27..bda47946c7ae9682738d09744094e493e0c23af6 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

@@ -10,7 +10,6 @@ import 'package:analysis_server/plugin/protocol/protocol.dart';

import 'package:analysis_server/src/provisional/completion/completion_core.dart'

show AnalysisRequest, CompletionContributor, CompletionRequest;

import 'package:analysis_server/src/provisional/completion/dart/completion_target.dart';

-import 'package:analysis_server/src/services/completion/arglist_contributor.dart';

import 'package:analysis_server/src/services/completion/combinator_contributor.dart';

import 'package:analysis_server/src/services/completion/completion_core.dart';

import 'package:analysis_server/src/services/completion/completion_manager.dart';

@@ -100,7 +99,7 @@ class DartCompletionManager extends CompletionManager {

new LocalReferenceContributor(),

new ImportedReferenceContributor(),

//new KeywordContributor(),

- new ArgListContributor(),

+ //new ArgListContributor(),

new CombinatorContributor(),

new PrefixedElementContributor(),

new UriContributor(),

@@ -110,10 +109,7 @@ class DartCompletionManager extends CompletionManager {

];

}

if (newContributors == null) {

- newContributors = <CompletionContributor>[

- // TODO(danrubel) initialize using plugin API

- //new newImpl.DartCompletionManager(),

- ];

+ newContributors = <CompletionContributor>[];

}

if (contributionSorter == null) {

contributionSorter = defaultContributionSorter;