Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 150079: Enable opening downloads from the Mac download shelf (Closed)

Created:
11 years, 5 months ago by Paul Godavari
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Enable opening downloads from the Mac download shelf. Also added a stub for an unused method on Canvas in order to link. TEST=Selecting "Open" from the shelf menu will open a download BUG=15661 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19691

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M app/gfx/canvas.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/download/download_shelf.cc View 1 2 3 chunks +1 line, -10 lines 0 comments Download
M chrome/chrome.gyp View 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Godavari
11 years, 5 months ago (2009-06-30 00:29:07 UTC) #1
pink (ping after 24hrs)
LGTM
11 years, 5 months ago (2009-06-30 12:34:28 UTC) #2
Paul Godavari
11 years, 5 months ago (2009-06-30 20:18:46 UTC) #3
I forgot to add the chrome.gyp change. Updated.

Powered by Google App Engine
This is Rietveld 408576698