Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1500783002: clang/win: Enable -Wunused-value completely. (Closed)

Created:
5 years ago by Nico
Modified:
5 years ago
Reviewers:
hans, Will Harris
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Enable -Wunused-value completely. BUG=505318 NOTRY=true Committed: https://crrev.com/b10a7ada601a07866d50cd13c6af4605e316152e Cr-Commit-Position: refs/heads/master@{#363327}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/installer/setup/setup_util_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/sid.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
Nico
wfh: sandbox/win hans: rest
5 years ago (2015-12-04 22:18:53 UTC) #2
hans
lgtm
5 years ago (2015-12-04 22:25:43 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500783002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500783002/40001
5 years ago (2015-12-04 22:48:28 UTC) #5
Will Harris
lgtm for sandbox/win
5 years ago (2015-12-05 00:24:36 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/150671)
5 years ago (2015-12-05 00:29:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500783002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500783002/40001
5 years ago (2015-12-05 01:04:38 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-05 01:11:55 UTC) #13
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/b10a7ada601a07866d50cd13c6af4605e316152e Cr-Commit-Position: refs/heads/master@{#363327}
5 years ago (2015-12-05 01:12:50 UTC) #15
Nico
5 years ago (2015-12-05 02:35:13 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1501153002/ by thakis@chromium.org.

The reason for reverting is: This works in debug builds but not in release
builds yet..

Powered by Google App Engine
This is Rietveld 408576698