Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 150073: Add a keyboard shortcut for the download page on Mac (Closed)

Created:
11 years, 5 months ago by Paul Godavari
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add a keyboard shortcut for opening the download page on Mac. Windows uses Ctrl + j, but the Mac equivalent (Cmd + j) is already in use for Edit -> Find -> Jump to Selection. I've chosen Cmd + Shift + j, as a replacement, but it's easy enough to change. TEST=Press the keyboard shortcut (Shift + Cmd + j) to open the download page. BUG=15653 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19637

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/app/nibs/en.lproj/MainMenu.xib View 1 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Godavari
11 years, 5 months ago (2009-06-29 23:26:38 UTC) #1
pink (ping after 24hrs)
11 years, 5 months ago (2009-06-30 12:31:52 UTC) #2
LGTM

http://codereview.chromium.org/150073/diff/1/2
File chrome/app/nibs/en.lproj/MainMenu.xib (right):

http://codereview.chromium.org/150073/diff/1/2#newcode2983
Line 2983: <string key="NS.key.0">showAllDownloadsLink_</string>
did you mean for this to sneak in?

Powered by Google App Engine
This is Rietveld 408576698