pkg/analysis_server/test/services/completion/completion_computer_test.dart - Issue 1500723002: hookup new CompletionContributorFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/services/completion/completion_computer_test.dart

Issue 1500723002: hookup new CompletionContributorFactory (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: fix comment Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/test/domain_completion_test.dart ('k') | pkg/analysis_server/test/services/completion/completion_manager_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/services/completion/completion_computer_test.dart

diff --git a/pkg/analysis_server/test/services/completion/completion_computer_test.dart b/pkg/analysis_server/test/services/completion/completion_computer_test.dart

index 7ab7583a3c9676e3c1fa1618586e3ad4f31a3b19..361485217d9e62c9a235958fb5a52105b8039a09 100644

--- a/pkg/analysis_server/test/services/completion/completion_computer_test.dart

+++ b/pkg/analysis_server/test/services/completion/completion_computer_test.dart

@@ -66,7 +66,8 @@ class DartCompletionManagerTest extends AbstractSingleUnitTest {

index = createLocalMemoryIndex();

searchEngine = new SearchEngineImpl(index);

source = addSource('/does/not/exist.dart', '');

- manager = new DartCompletionManager.create(context, searchEngine, source);

+ manager =

+ new DartCompletionManager.create(context, searchEngine, source, []);

suggestion1 = new CompletionSuggestion(CompletionSuggestionKind.INVOCATION,

DART_RELEVANCE_DEFAULT, "suggestion1", 1, 1, false, false);

suggestion2 = new CompletionSuggestion(CompletionSuggestionKind.IDENTIFIER,

@@ -83,7 +84,6 @@ class DartCompletionManagerTest extends AbstractSingleUnitTest {

contributor1 = new MockCompletionContributor(suggestion1, null);

contributor2 = new MockCompletionContributor(null, suggestion2);

manager.contributors = [contributor1, contributor2];

- manager.newContributors = [];

int count = 0;

bool done = false;

CompletionRequest completionRequest =

@@ -121,7 +121,6 @@ class DartCompletionManagerTest extends AbstractSingleUnitTest {