Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: pkg/analysis_server/lib/src/services/completion/completion_manager.dart

Issue 1500723002: hookup new CompletionContributorFactory (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: fix comment Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/completion_manager.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/completion_manager.dart
index c79a9db64da576ad44bf6cd0f4e733159b9e8a25..c559a8059127179a6f494b5ebe4a66f846bc56a2 100644
--- a/pkg/analysis_server/lib/src/services/completion/completion_manager.dart
+++ b/pkg/analysis_server/lib/src/services/completion/completion_manager.dart
@@ -8,7 +8,7 @@ import 'dart:async';
import 'package:analysis_server/plugin/protocol/protocol.dart';
import 'package:analysis_server/src/provisional/completion/completion_core.dart'
- show CompletionRequest, CompletionResult;
+ show CompletionContributor, CompletionContributorFactory, CompletionRequest, CompletionResult;
import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
import 'package:analysis_server/src/services/search/search_engine.dart';
import 'package:analyzer/src/generated/engine.dart';
@@ -57,14 +57,14 @@ abstract class CompletionManager {
* Create a manager for the given request.
*/
factory CompletionManager.create(
- AnalysisContext context, Source source, SearchEngine searchEngine) {
+ AnalysisContext context,
+ Source source,
+ SearchEngine searchEngine,
+ Iterable<CompletionContributor> newContributors) {
if (context != null) {
if (AnalysisEngine.isDartFileName(source.shortName)) {
- return new DartCompletionManager.create(context, searchEngine, source);
- }
- if (AnalysisEngine.isHtmlFileName(source.shortName)) {
- //TODO (danrubel) implement
-// return new HtmlCompletionManager(context, searchEngine, source, offset);
+ return new DartCompletionManager.create(
+ context, searchEngine, source, newContributors);
}
}
return new NoOpCompletionManager(source);

Powered by Google App Engine
This is Rietveld 408576698